From: Kalle Valo <kvalo@codeaurora.org>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: "Rafał Miłecki" <zajec5@gmail.com>,
"Arend Van Spriel" <arend.vanspriel@broadcom.com>,
"Franky Lin" <franky.lin@broadcom.com>,
"Hante Meuleman" <hante.meuleman@broadcom.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER"
<brcm80211-dev-list.pdl@broadcom.com>,
"Network Development" <netdev@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Arnd Bergmann" <arnd@arndb.de>,
xie.baoyou@zte.com.cn
Subject: Re: [PATCH v4] brcmfmac: add missing header dependencies
Date: Tue, 30 Aug 2016 19:08:33 +0300 [thread overview]
Message-ID: <87twe244u6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+DQWkxpoScXLNhScNpwmLnaMhgVHoGLrH72dAm7OiOX2nW2vA@mail.gmail.com> (Baoyou Xie's message of "Tue, 30 Aug 2016 19:15:35 +0800")
Baoyou Xie <baoyou.xie@linaro.org> writes:
> On 29 August 2016 at 23:31, Rafał Miłecki <zajec5@gmail.com> wrote:
>
> On 29 August 2016 at 14:39, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> > We get 1 warning when build kernel with W=1:
> > drivers/net/wireless/broadcom/brcm80211/brcmfmac/tracepoint.c:23:6:
> warning: no previous prototype for '__brcmf_err' [-Wmissing-prototypes]
>
> building? I'm not native English, but I think so.
>
>
> > In fact, this function is declared in brcmfmac/debug.h, so this patch
> > add missing header dependencies.
>
> adds
>
>
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> Please don't resend patches just to add tags like that. This only
> increases a noise and patchwork handles this just fine, see:
> https://patchwork.kernel.org/patch/9303285/
> https://patchwork.kernel.org/patch/9303285/mbox/
>
>
> Do I need to resend a patch that fixes two typos(build/add)? or you modify them
> on your way?
I can fix those when I commit the patch.
--
Kalle Valo
next prev parent reply other threads:[~2016-08-30 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 12:39 [PATCH v4] brcmfmac: add missing header dependencies Baoyou Xie
2016-08-29 15:31 ` Rafał Miłecki
2016-08-29 16:39 ` Rafał Miłecki
[not found] ` <CA+DQWkxpoScXLNhScNpwmLnaMhgVHoGLrH72dAm7OiOX2nW2vA@mail.gmail.com>
2016-08-30 16:08 ` Kalle Valo [this message]
2016-09-03 10:10 ` [v4] " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twe244u6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox