From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Ben Greear <greearb@candelatech.com>
Cc: Michal Kazior <michal.kazior@tieto.com>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v7 2/8] ath10k: provide firmware crash info via debugfs
Date: Wed, 20 Aug 2014 10:29:27 +0300 [thread overview]
Message-ID: <87tx5762lk.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <53F36C63.8040809@candelatech.com> (Ben Greear's message of "Tue, 19 Aug 2014 08:25:23 -0700")
Ben Greear <greearb@candelatech.com> writes:
>>> + /* Gather dbg-log */
>>> + dump_tlv = (struct ath10k_tlv_dump_data *)(buf + sofar);
>>> + dump_tlv->type = cpu_to_le32(ATH10K_FW_CRASH_DUMP_DBGLOG);
>>> + dump_tlv->tlv_len = cpu_to_le32(sizeof(crash_data->dbglog_entry_data));
>>
>> Hmm should this really be sizeof()? Not next_idx (which effectively
>> defines number of bytes of the dbglog)?
>
> I haven't tried decoding this yet, but we may need to know the next_idx
> to decode this properly.
I really don't like the idea of having untested code in ath10k. Buggy
code is okay (preferably document the known bugs when submitting code),
but untested code is not.
--
Kalle Valo
next prev parent reply other threads:[~2014-08-20 7:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 8:22 [PATCH v7 0/8] ath10k: firmware crash dump Kalle Valo
2014-08-19 8:22 ` [PATCH v7 1/8] ath10k: add ath10k_pci_diag_* helpers Kalle Valo
2014-08-19 8:22 ` [PATCH v7 2/8] ath10k: provide firmware crash info via debugfs Kalle Valo
2014-08-19 9:33 ` Michal Kazior
2014-08-19 15:25 ` Ben Greear
2014-08-19 16:05 ` Ben Greear
2014-08-20 7:36 ` Kalle Valo
2014-08-20 6:28 ` Michal Kazior
2014-08-20 6:48 ` Kalle Valo
2014-08-20 6:56 ` Kalle Valo
2014-08-20 13:13 ` Ben Greear
2014-08-20 7:29 ` Kalle Valo [this message]
2014-08-20 13:08 ` Ben Greear
2014-08-20 14:19 ` Kalle Valo
2014-08-20 14:52 ` Ben Greear
2014-08-19 8:23 ` [PATCH v7 3/8] ath10k: save firmware debug log messages Kalle Valo
2014-08-19 9:39 ` Michal Kazior
2014-08-19 9:44 ` Michal Kazior
2014-08-19 15:16 ` Ben Greear
2014-08-19 8:23 ` [PATCH v7 4/8] ath10k: save firmware stack upon firmware crash Kalle Valo
2014-08-19 9:37 ` Michal Kazior
2014-08-19 8:23 ` [PATCH v7 5/8] ath10k: dump exception stack contents on " Kalle Valo
2014-08-19 9:38 ` Michal Kazior
2014-08-19 8:23 ` [PATCH v7 6/8] ath10k: save firmware RAM and ROM BSS sections on crash Kalle Valo
2014-08-19 9:39 ` Michal Kazior
2014-08-19 8:23 ` [PATCH v7 7/8] ath10k: rename ath10k_pci_hif_dump_area() to ath10k_pci_fw_crashed_dump() Kalle Valo
2014-08-19 8:23 ` [PATCH v7 8/8] ath10k: print more driver info when firmware crashes Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx5762lk.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).