From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Marek Kwaczynski <marek.kwaczynski@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: Set proper nss value for the peer
Date: Thu, 13 Feb 2014 16:50:08 +0200 [thread overview]
Message-ID: <87txc383tr.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1392027925-8321-1-git-send-email-marek.kwaczynski@tieto.com> (Marek Kwaczynski's message of "Mon, 10 Feb 2014 11:25:25 +0100")
Marek Kwaczynski <marek.kwaczynski@tieto.com> writes:
> It was found during testing the nss calculation does not
> cover all corner cases. Station could request eq. only MCS8
> and MCS9 (nss=2 specific). Next num_rates=2 so the driver
> sets nss=(max((2+7)/8, 1))=1. Which is wrong. The in-driver
> calculation was introduced prior (commit ddcc347b70
> mac80211: fix rx_nss calculation for drivers with hw rc).
> Since it's fixed, use mac80211 provided value from now.
> End user will experience lower throuhputs than expected
> if the nss is wrongly calculated.
>
> Signed-off-by: Marek Kwaczynski <marek.kwaczynski@tieto.com>
Thanks, applied.
--
Kalle Valo
next prev parent reply other threads:[~2014-02-13 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 10:25 [PATCH] ath10k: Set proper nss value for the peer Marek Kwaczynski
2014-02-13 14:50 ` Kalle Valo [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-02-10 10:22 Marek Kwaczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txc383tr.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=marek.kwaczynski@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).