From: Kalle Valo <kalle.valo@nokia.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: Vivek Natarajan <vnatarajan@atheros.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [RFC v3] mac80211: extend/document powersave API
Date: Wed, 07 Jan 2009 19:25:09 +0200 [thread overview]
Message-ID: <87tz8b3u6i.fsf@nokia.com> (raw)
In-Reply-To: <1231346625.3545.56.camel@johannes> (ext Johannes Berg's message of "Wed\, 07 Jan 2009 17\:43\:45 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> This modifies hardware flags for powersave to support three different
> flags:
> * IEEE80211_HW_SUPPORTS_PS - indicates general PS support
> * IEEE80211_HW_PS_NULLFUNC_STACK - indicates nullfunc sending in software
> * IEEE80211_HW_SUPPORTS_DYNAMIC_PS - indicates dynamic PS on the device
>
> It also adds documentation for all this which explains how to set the
> various flags.
>
> Additionally, it fixes a few things:
> * a spot where && was used to test flags
> * enable CONF_PS only when associated again
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Looks good to me.
Reviewed-by: Kalle Valo <kalle.valo@nokia.com>
> -set:
> + set:
Really? My emacs always indents it without space, should I fix my
settings?
--
Kalle Valo
next prev parent reply other threads:[~2009-01-07 17:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-06 17:53 [RFC] mac80211: extend/document powersave API Johannes Berg
2009-01-06 20:25 ` [RFC v2] " Johannes Berg
2009-01-07 15:49 ` Kalle Valo
2009-01-07 15:56 ` Johannes Berg
2009-01-07 16:22 ` Kalle Valo
2009-01-07 16:43 ` [RFC v3] " Johannes Berg
2009-01-07 17:25 ` Kalle Valo [this message]
2009-01-07 17:31 ` Johannes Berg
2009-01-07 17:49 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tz8b3u6i.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vnatarajan@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).