From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9584114884F for ; Tue, 17 Sep 2024 11:18:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726571894; cv=none; b=Exrj/f4Ez5ANjeKP3mwEp/t1heCmjeIMczRhMAQw5njaKXteBlSp7IadlQlC0NOyZWhO+MCLUYSeKs57ZkHpBlcYxRzBC2npS16P7atmlCs1jx7F9Yhr6+FnliLWoRskEQ62D2OBn8k6TcA2nMTJTwYZOO+3dxuYtjhMKvrFNj0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726571894; c=relaxed/simple; bh=juqXg4Sm5EwoRb+w7z2ye1c9d9jKiPkIiyfpTiStrX4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=h6Thm69b95sH6Yzpv+69Ex8FV7rqij5FQVhM8L6dACwboLTGlXgwNdNTGzuzqm1lq0SGMAAbG1zoilrrzszGsmkvrU7T6V68IJxNlMgYSlGfMI9NSWZQbqHuuSzRJ9BRQMr6S+dkjEobnmKINaHVp90sEdQZCvMHqPbp3qVVt58= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CpR2c6xf; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CpR2c6xf" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C6E6C4CECE; Tue, 17 Sep 2024 11:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1726571894; bh=juqXg4Sm5EwoRb+w7z2ye1c9d9jKiPkIiyfpTiStrX4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=CpR2c6xfQOwOcsus0oy6LgfMjkwSw6Y/W/AaR5Oq5tiMaH1v7zhZJN1hkWle4EwqT kS4wQiiSmXmO+HRBOZizDYndvMtNU2C8sekxGicPVc7acaNJzSlauB5u1xPiSu3xdI WalYwliwpBCoDMtjYwU0mhSAUM151Up2/9vn9OwEMWC54z76mottL+GLZSWuUghbG2 WG3HPyrGS37A+etrBGLL4dEAY9LuimWzhD78EjEJEwDeUtOwCqFE7rHPjBOHzAFZQW EVtGDDplHE3NgQvTMN9c7Eohf6EjYLDVd2u3RsgbhWlXct3lxyuq+R1JJkZtWtaggT 2+hKSSdpeNLEA== From: Kalle Valo To: Felix Fietkau Cc: linux-wireless@vger.kernel.org, =?utf-8?Q?N=C3=ADcolas?= F. R. A. Prado , Alper Nebi Yasak Subject: Re: [PATCH] wifi: mt76: do not increase mcu skb refcount if retry is not supported References: <20240917110942.22077-1-nbd@nbd.name> Date: Tue, 17 Sep 2024 14:18:11 +0300 In-Reply-To: <20240917110942.22077-1-nbd@nbd.name> (Felix Fietkau's message of "Tue, 17 Sep 2024 13:09:42 +0200") Message-ID: <87v7yua5qk.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Felix Fietkau writes: > If mcu_skb_prepare_msg is not implemented, incrementing skb refcount does= not > work for mcu message retry. In some cases (e.g. on SDIO), shared skbs can= trigger > a BUG_ON, crashing the system. > Fix this by only incrementing refcount if retry is actually supported. > > Fixes: 3688c18b65ae ("wifi: mt76: mt7915: retry mcu messages") > Reported-by: N=C3=ADcolas F. R. A. Prado #Kerne= lCI > Tested-by: Alper Nebi Yasak > Signed-off-by: Felix Fietkau I'll queue this to wireless tree and add: Closes: https://lore.kernel.org/r/d907b13a-f8be-4cb8-a0bb-560a21278041@nota= piano/ Ok? --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes