From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5823C4332F for ; Thu, 17 Nov 2022 10:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234636AbiKQKsn (ORCPT ); Thu, 17 Nov 2022 05:48:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239165AbiKQKsi (ORCPT ); Thu, 17 Nov 2022 05:48:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F10C76443 for ; Thu, 17 Nov 2022 02:48:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AB736B81FF5 for ; Thu, 17 Nov 2022 10:48:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95B10C433D6; Thu, 17 Nov 2022 10:48:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668682111; bh=Z7aP4Ho75AfGbQk6LzW1BZcM6gY0Fi0ogtvT0WPQLgc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=ILawBLuQWHfRG2SeLj30v077GjNxUC7ErXZvvRZb6XZ4AhS6W7mS83SpQ3YSm89Tk 3Ix3uAFbq/B7KQhzAgZfn9Z6xBPvcgcUtfecpob3vK0rxTgUhvs9KmWlHKRO4VvyQ2 xMQs2U5AzHh6Gvvo2glBLBE/asDq04RhLJhE+W2Q+uvlSI0w5jIBo+GiZxmzrdMEJa GTRnTqYQUH1w6QAO9F9ZZu66tXR2MsIuVIgAcSJ8jC3XEXnfIi36YSxcqk9jUADhIY 3+VNQAUw4TVpRiKsQnu3Ncw/k3V4rP5OWOwJ2+6LtHCHGKzB4Jn8kq/wj3bIi6yVS5 6/7GztZhnoMPA== From: Kalle Valo To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Johannes Berg Subject: Re: [RFC PATCH 1/2] wifi: wireless: warn on most wireless extension usage References: <20221104174218.26f9541c0bfa.Ifcf30eeeb8fc7019e4dcf2782b04515254d165e1@changeid> Date: Thu, 17 Nov 2022 12:48:24 +0200 In-Reply-To: <20221104174218.26f9541c0bfa.Ifcf30eeeb8fc7019e4dcf2782b04515254d165e1@changeid> (Johannes Berg's message of "Fri, 4 Nov 2022 17:42:20 +0100") Message-ID: <87v8ndrh53.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > From: Johannes Berg > > With MLO/EHT support around the corner, we're going to > remove support for wireless extensions with new devices > since MLO cannot be properly indicated using them. > > Add a warning to indicate which processes are still > using wireless extensions, if being used with modern > (i.e. cfg80211) drivers. I doubt people outside of wireless know what MLO or EHT are :) Also it would be good to mention what's the replacement for wireless extensions so better to spell out that as well. So maybe use more widely known terminology like this: "With Wi-Fi 7 (IEEE 802.11be) support around the corner, we're going to remove support for wireless extensions with new devices since Multi-Link Operation (MLO) feature cannot be properly indicated using them. Add a warning to indicate which processes are still using the ancient wireless extensions, if being used with modern (i.e. cfg80211) drivers. All those users should be using nl80211 instead. Ancient drivers, which are not using cfg80211, are unaffected." > +#ifdef CONFIG_CFG80211_WEXT > +static void wireless_warn_cfg80211_wext(void) > +{ > + char name[sizeof(current->comm)]; > > + pr_warn_ratelimited("warning: `%s' uses wireless extensions that are deprecated for modern drivers\n", > + get_task_comm(name, current)); > +} > +#endif Maybe add ", switch to nl80211" also to the warning message? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches