From: Kalle Valo <kvalo@kernel.org>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Jes Sorensen <Jes.Sorensen@gmail.com>,
chris.chiu@canonical.com
Subject: Re: [PATCH v2] wifi: rtl8xxxu: Support new chip RTL8188FU
Date: Thu, 29 Sep 2022 09:23:46 +0300 [thread overview]
Message-ID: <87v8p6r959.fsf@kernel.org> (raw)
In-Reply-To: <b8af19f6-564e-d592-0993-6b4c33728ac4@gmail.com> (Bitterblue Smith's message of "Wed, 28 Sep 2022 20:53:36 +0300")
Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
> On 26/09/2022 12:22, Kalle Valo wrote:
>
>> Bitterblue Smith <rtl8821cerfe2@gmail.com> writes:
>>
>> [...]
>>
>>> +static struct rtl8xxxu_reg8val rtl8188f_mac_init_table[] = {
>>
>> [...]
>>
>>> +static struct rtl8xxxu_reg32val rtl8188fu_phy_init_table[] = {
>>
>> [...]
>>
>>> +static struct rtl8xxxu_reg32val rtl8188f_agc_table[] = {
>>
>> [...]
>>
>>> +static struct rtl8xxxu_rfregval rtl8188fu_radioa_init_table[] = {
>>
>> [...]
>>
>>> +static struct rtl8xxxu_rfregval rtl8188fu_cut_b_radioa_init_table[] = {
>>
>> Can these arrays be static const?
>>
> Only if I modify the functions rtl8xxxu_init_phy_regs and
> rtl8xxxu_init_phy_rf, and the struct rtl8xxxu_fileops. Otherwise the
> compiler complains about discarded const. Perhaps in a future patch?
Yeah, a future patch sounds good.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2022-09-29 6:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-17 21:06 [PATCH v2] wifi: rtl8xxxu: Support new chip RTL8188FU Bitterblue Smith
2022-09-26 9:22 ` Kalle Valo
2022-09-28 17:53 ` Bitterblue Smith
2022-09-29 6:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8p6r959.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Jes.Sorensen@gmail.com \
--cc=chris.chiu@canonical.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).