* [PATCH 6.0] wifi: mt76: fix reading current per-tid starting sequence number for aggregation
@ 2022-08-26 18:23 Felix Fietkau
2022-09-08 7:01 ` Kalle Valo
2022-09-12 11:25 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Felix Fietkau @ 2022-08-26 18:23 UTC (permalink / raw)
To: linux-wireless; +Cc: kvalo
The code was accidentally shifting register values down by tid % 32 instead of
(tid * field_size) % 32.
Cc: stable@vger.kernel.org
Fixes: a28bef561a5c ("mt76: mt7615: re-enable offloading of sequence number assignment")
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
drivers/net/wireless/mediatek/mt76/mt7615/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
index ad6c7d632eed..d6aae60c440d 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mac.c
@@ -1088,7 +1088,7 @@ u32 mt7615_mac_get_sta_tid_sn(struct mt7615_dev *dev, int wcid, u8 tid)
offset %= 32;
val = mt76_rr(dev, addr);
- val >>= (tid % 32);
+ val >>= offset;
if (offset > 20) {
addr += 4;
--
2.36.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 6.0] wifi: mt76: fix reading current per-tid starting sequence number for aggregation
2022-08-26 18:23 [PATCH 6.0] wifi: mt76: fix reading current per-tid starting sequence number for aggregation Felix Fietkau
@ 2022-09-08 7:01 ` Kalle Valo
2022-09-12 11:25 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-09-08 7:01 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless
Felix Fietkau <nbd@nbd.name> writes:
> The code was accidentally shifting register values down by tid % 32 instead of
> (tid * field_size) % 32.
>
> Cc: stable@vger.kernel.org
> Fixes: a28bef561a5c ("mt76: mt7615: re-enable offloading of sequence number assignment")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
I assigned this to myself on patchwork and I'll queue this for v6.0.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 6.0] wifi: mt76: fix reading current per-tid starting sequence number for aggregation
2022-08-26 18:23 [PATCH 6.0] wifi: mt76: fix reading current per-tid starting sequence number for aggregation Felix Fietkau
2022-09-08 7:01 ` Kalle Valo
@ 2022-09-12 11:25 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-09-12 11:25 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless
Felix Fietkau <nbd@nbd.name> wrote:
> The code was accidentally shifting register values down by tid % 32 instead of
> (tid * field_size) % 32.
>
> Cc: stable@vger.kernel.org
> Fixes: a28bef561a5c ("mt76: mt7615: re-enable offloading of sequence number assignment")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
Patch applied to wireless.git, thanks.
c3a510e2b537 wifi: mt76: fix reading current per-tid starting sequence number for aggregation
--
https://patchwork.kernel.org/project/linux-wireless/patch/20220826182329.18155-1-nbd@nbd.name/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-12 11:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-26 18:23 [PATCH 6.0] wifi: mt76: fix reading current per-tid starting sequence number for aggregation Felix Fietkau
2022-09-08 7:01 ` Kalle Valo
2022-09-12 11:25 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).