From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH wireless-next 2/3] wifi: ath10k: remove a copy of the NAPI_POLL_WEIGHT define
Date: Fri, 29 Apr 2022 22:06:20 +0300 [thread overview]
Message-ID: <87v8urd80j.fsf@kernel.org> (raw)
In-Reply-To: <20220429174643.196994-3-kuba@kernel.org> (Jakub Kicinski's message of "Fri, 29 Apr 2022 10:46:42 -0700")
Jakub Kicinski <kuba@kernel.org> writes:
> Defining local versions of NAPI_POLL_WEIGHT with the same
> values in the drivers just makes refactoring harder.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: kvalo@kernel.org
> CC: ath10k@lists.infradead.org
> CC: linux-wireless@vger.kernel.org
> ---
> drivers/net/wireless/ath/ath10k/core.h | 3 ---
> drivers/net/wireless/ath/ath10k/pci.c | 2 +-
> drivers/net/wireless/ath/ath10k/sdio.c | 2 +-
> drivers/net/wireless/ath/ath10k/snoc.c | 2 +-
> 4 files changed, 3 insertions(+), 6 deletions(-)
This failed to build as recently usb.c got napi poll as well, I fixed it
in the pending branch:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=89fc2e14d3e50cad605104572228d3740df7ca77
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2022-04-29 19:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 17:46 [PATCH wireless-next 0/3] wifi: remove copies of the NAPI_POLL_WEIGHT define Jakub Kicinski
2022-04-29 17:46 ` [PATCH wireless-next 1/3] wifi: rtw88: remove a copy " Jakub Kicinski
2022-05-02 14:38 ` [wireless-next,1/3] " Kalle Valo
2022-04-29 17:46 ` [PATCH wireless-next 2/3] wifi: ath10k: " Jakub Kicinski
2022-04-29 19:06 ` Kalle Valo [this message]
2022-04-29 19:16 ` Jakub Kicinski
2022-05-02 14:00 ` Kalle Valo
2022-04-29 17:46 ` [PATCH wireless-next 3/3] wifi: wil6210: use NAPI_POLL_WEIGHT for napi budget Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8urd80j.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath10k@lists.infradead.org \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).