Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Denis Kalashnikov <denis281089@gmail.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/1] ath9k: fix firmware bug in some of Mikrotik R11e-2HPnD cards
Date: Fri, 10 Jan 2020 10:27:12 +0200	[thread overview]
Message-ID: <87v9pjsom7.fsf@codeaurora.org> (raw)
In-Reply-To: <CAKoLU8M+QU-96vnfet-759nnXyxxJmsf1Csba4FgNas8ZVOnOQ@mail.gmail.com> (Denis Kalashnikov's message of "Fri, 27 Dec 2019 10:18:05 +0300")

Denis Kalashnikov <denis281089@gmail.com> writes:

> Some of the Mikrotik R11e-2HPnD cards have EEPROM where is
> flashed that a card has 3 chains, but actually all this cards
> have only 2. This leads ath9k to write periodically into the logs:
> 'ath: phy0: Unable to reset channel, reset status -5' and
> stations don't see that AP.
>
> Mikrotik R11e-2HPnD is based on AR9582 chip.
>
> Signed-off-by: Denis Kalashnikov <denis281089@gmail.com>
> ---
>  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> index b4885a700296..554a81400648 100644
> --- a/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> +++ b/drivers/net/wireless/ath/ath9k/ar9003_eeprom.c
> @@ -3373,6 +3373,15 @@ static int
> ar9300_eeprom_restore_internal(struct ath_hw *ah,
>                 cptr -= (COMP_HDR_LEN + osize + COMP_CKSUM_LEN);
>         }
>
> +       /**
> +        * Fix firmware bug of some Mikrotik R11e-2HPnD cards (based on AR9582)
> +        * that claim that they have 3 chains, but actually have only 2.
> +        */
> +       if (AR_SREV_9580(ah)) {
> +               eep = (struct ar9300_eeprom *)mptr;
> +               eep->baseEepHeader.txrxMask &= 0x33;
> +       }

What about 9580 devices which really have 3 chains, doesn't this broke
those? Or is such setup impossible?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2020-01-10  8:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-27  7:18 [PATCH 1/1] ath9k: fix firmware bug in some of Mikrotik R11e-2HPnD cards Denis Kalashnikov
2020-01-10  8:27 ` Kalle Valo [this message]
2020-01-10 11:37   ` Denis Kalashnikov
2020-01-10 11:38   ` Tom Psyborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v9pjsom7.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=denis281089@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox