From: Kalle Valo <kvalo@codeaurora.org>
To: Igor Stoppa <igor.stoppa@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Igor Stoppa <igor.stoppa@huawei.com>,
Christian Lamparter <chunkeey@googlemail.com>,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH 10/23] wireless: remove unnecessary unlikely()
Date: Fri, 31 Aug 2018 12:52:33 +0300 [thread overview]
Message-ID: <87va7qdfry.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20180830223429.30051-11-igor.stoppa@huawei.com> (Igor Stoppa's message of "Fri, 31 Aug 2018 01:34:16 +0300")
+ linux-wireless
Igor Stoppa <igor.stoppa@gmail.com> writes:
> WARN_ON_ONCE() already contains an unlikely(), and the logical or of two of
> them is still unlikely(), so it's not necessary to wrap them into another.
>
> Signed-off-by: Igor Stoppa <igor.stoppa@huawei.com>
> Cc: Christian Lamparter <chunkeey@googlemail.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
IMHO you could fold patches 10, 11 and 12 into one to avoid having three
patches with duplicate titles. Or alternatively use proper driver
prefixes like "ath10k:", "b43:" and so on.
But how do you want these to be applied? For the wireless patches you
didn't Cc linux-wireless so our patchwork won't see them and hence I
can't take them. So if you want me to take these, please resend and
include linux-wireless.
--
Kalle Valo
next parent reply other threads:[~2018-08-31 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180830223429.30051-1-igor.stoppa@huawei.com>
[not found] ` <20180830223429.30051-11-igor.stoppa@huawei.com>
2018-08-31 9:52 ` Kalle Valo [this message]
2018-08-31 13:44 ` [PATCH 10/23] wireless: remove unnecessary unlikely() Igor Stoppa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87va7qdfry.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=chunkeey@googlemail.com \
--cc=igor.stoppa@gmail.com \
--cc=igor.stoppa@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).