linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: Steve deRosier <derosier@gmail.com>,
	Samuel Sieb <samuel@sieb.net>,
	"linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>
Subject: Re: Max clients on wifi access point with 7265
Date: Tue, 27 Feb 2018 10:33:17 +0200	[thread overview]
Message-ID: <87vaeihlwy.fsf@codeaurora.org> (raw)
In-Reply-To: <1519039105.7832.94.camel@coelho.fi> (Luca Coelho's message of "Mon, 19 Feb 2018 13:18:25 +0200")

Luca Coelho <luca@coelho.fi> writes:

>> > We do have wiphy::max_ap_assoc_sta, but I see only ath10k, qtnfmac
>> > and
>> > rsi_91x setting it. I wish all drivers would use that.
>> > 
>> >  * @max_ap_assoc_sta: maximum number of associated stations
>> > supported in AP mode
>> >  * (including P2P GO) or 0 to indicate no such limit is advertised.
>> > The
>> >  * driver is allowed to advertise a theoretical limit that it can
>> > reach in
>> >  * some cases, but may not always reach.
>> 
>> Cool, I hadn't noticed this before.  I'll add a patch to iwlwifi to
>> add it.
>
> Actually this is not so straightforward, because every time we add a
> p2p vif, we lose one more station.  So the max_ap_assoc_sta value must
> be dynamic (or we can state the theoretical lowest number to start
> with, which would not be very nice).
>
> I don't think this feature is worth the trouble, so I'll skip it for
> now.

I think the documentation answers that part pretty well:

  "The driver is allowed to advertise a theoretical limit that it can
   reach in some cases, but may not always reach."

So I still thank having the drivers to advertise the theoretical maximum
numbers of client is useful, even if it would not be always 100%
correct. For example, an average user most likely will not have any clue
if the limit is 10, 50 or 100 clients. And besides, very few people use
P2P anyway ;)

But of course this is just nice-to-have category cand we have far more
important things to fix first.

-- 
Kalle Valo

  reply	other threads:[~2018-02-27  8:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-14 10:55 Max clients on wifi access point with 7265 Mickaël PANNEQUIN
2018-02-14 11:30 ` Johannes Berg
2018-02-14 22:04   ` Samuel Sieb
2018-02-14 22:36     ` Johannes Berg
2018-02-14 22:38     ` Steve deRosier
2018-02-19  6:07       ` Kalle Valo
2018-02-19  9:26         ` Luca Coelho
2018-02-19 11:18           ` Luca Coelho
2018-02-27  8:33             ` Kalle Valo [this message]
2018-02-27 17:56               ` Steve deRosier
2018-02-28 12:14                 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vaeihlwy.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=derosier@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luca@coelho.fi \
    --cc=samuel@sieb.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).