From: Kalle Valo <kvalo@codeaurora.org>
To: Xinming Hu <huxm@marvell.com>
Cc: Linux Wireless <linux-wireless@vger.kernel.org>,
Brian Norris <briannorris@chromium.org>,
Dmitry Torokhov <dtor@google.com>, <rajatja@google.com>,
Zhiyuan Yang <yangzy@marvell.com>, Tim Song <songtao@marvell.com>,
Cathy Luo <cluo@marvell.com>, James Cao <jcao@marvell.com>,
Ganapathi Bhat <gbhat@marvell.com>,
Ellie Reeves <ellierevves@gmail.com>
Subject: Re: [RESEND, PATCH v3 3/3] mwifiex: debugfs: trigger device dump for usb interface
Date: Mon, 04 Dec 2017 11:46:09 +0200 [thread overview]
Message-ID: <87vahmvna6.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1512370563-24660-1-git-send-email-huxm@marvell.com> (Xinming Hu's message of "Mon, 4 Dec 2017 14:56:03 +0800")
Xinming Hu <huxm@marvell.com> writes:
> This patch extend device_dump debugfs function to make it
> works for usb interface.
>
> For command timeouts, USB firmware will automatically emit
> firmware dump events, so we don't implement device_dump().
>
> For user-initiated dumps, we trigger it by issue firmware
> dump event command to firmware, as there is no command
> response, do not start 10s timer.
>
> Signed-off-by: Xinming Hu <huxm@marvell.com>
> Signed-off-by: Cathy Luo <cluo@marvell.com>
> ---
> v2: Same as v1
> v3: Add more comments Regards the different dump mechanism
> between usb and other interfaces.(Brian Norris)
Please always resubmit the whole patchset, not individual patches:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#resubmit_the_whole_patchset
Also please don't use that awkward "RESEND" stuff some people seem to
insist using. So instead of doing like this:
v2, v3, v3 RESEND, v4
do it like this which makes my life easier:
v2, v3, v4, v5
It's not like we are running out of version numbers :)
--
Kalle Valo
prev parent reply other threads:[~2017-12-04 9:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 6:56 [RESEND, PATCH v3 3/3] mwifiex: debugfs: trigger device dump for usb interface Xinming Hu
2017-12-04 9:46 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vahmvna6.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=briannorris@chromium.org \
--cc=cluo@marvell.com \
--cc=dtor@google.com \
--cc=ellierevves@gmail.com \
--cc=gbhat@marvell.com \
--cc=huxm@marvell.com \
--cc=jcao@marvell.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rajatja@google.com \
--cc=songtao@marvell.com \
--cc=yangzy@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox