From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Souptick Joarder <jrdr.linux@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v4] rtlwifi: Replace hardcode value with macro
Date: Wed, 02 Aug 2017 12:21:15 +0300 [thread overview]
Message-ID: <87vam6496c.fsf@codeaurora.org> (raw)
In-Reply-To: <8af42486-dd0b-bda6-6125-148dc0011115@lwfinger.net> (Larry Finger's message of "Mon, 31 Jul 2017 09:18:51 -0500")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> On 07/31/2017 06:14 AM, Souptick Joarder wrote:
>> In _rtl_init_mac80211(), hardcoded value for hw->max_listen_interval
>> and hw->max_rate_tries are replaced by macro.
>
> That is NOT what your patch does. It only removes a comment! Granted,
> that comment is useless and should come out, but your commit message
> must be a little more accurate.
Actually the patch does not even apply, I suspect that Souptick
incorrectly used v3 of his patch as the baseline for v4. Instead this v4
should be folded with v3.
--
Kalle Valo
next prev parent reply other threads:[~2017-08-02 9:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 11:14 [PATCH v4] rtlwifi: Replace hardcode value with macro Souptick Joarder
2017-07-31 14:18 ` Larry Finger
2017-08-02 9:21 ` Kalle Valo [this message]
2017-08-02 10:47 ` Souptick Joarder
2017-08-02 10:50 ` Arend van Spriel
-- strict thread matches above, loose matches on Subject: below --
2017-08-02 11:59 Souptick Joarder
2017-08-02 12:10 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vam6496c.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=jrdr.linux@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).