From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:60550 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbdAQLth (ORCPT ); Tue, 17 Jan 2017 06:49:37 -0500 From: Kalle Valo To: Stephen Rothwell Cc: Wireless , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, Xinming Hu , Amitkumar Karwar Subject: Re: linux-next: build warning after merge of the wireless-drivers-next tree References: <20170113111250.2023a160@canb.auug.org.au> <87shonjcle.fsf@codeaurora.org> Date: Tue, 17 Jan 2017 13:49:31 +0200 In-Reply-To: <87shonjcle.fsf@codeaurora.org> (Kalle Valo's message of "Fri, 13 Jan 2017 15:47:41 +0200") Message-ID: <87vatdhpo4.fsf@purkki.adurom.net> (sfid-20170117_124950_937638_7A261ED5) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo writes: > Stephen Rothwell writes: > >> Hi all, >> >> After merging the wireless-drivers-next tree, today's linux-next build >> (x86_64 allmodconfig) produced this warning: >> >> drivers/net/wireless/marvell/mwifiex/pcie.c: In function 'mwifiex_pcie_remove': >> drivers/net/wireless/marvell/mwifiex/pcie.c:303:5: warning: 'fw_status' may be used uninitialized in this function [-Wmaybe-uninitialized] >> if (fw_status == FIRMWARE_READY_PCIE && !adapter->mfg_mode) { >> ^ >> >> Introduced by commit >> >> 045f0c1b5e26 ("mwifiex: get rid of global user_rmmod flag") >> >> This is not a false positive since "reg" could be NULL just above >> (otherwise it would be tested for). > > Thanks, I noticed this myself yesterday (after I had applied the patch) > and I have asked Marvell to send a fix. I missed that Arnd had already sent a fix, I'll apply that one: mwifiex: fix uninitialized variable access in pcie_remove https://patchwork.kernel.org/patch/9515899/ -- Kalle Valo