Re: [PATCH] ath9k_htc: Add a module parameter to disable blink

[Hong Xu <hong@topbug.net>]

[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]


Julian Calaby <julian.calaby@gmail.com> writes:

> Hi Hong,
>
> On Mon, Jan 12, 2015 at 6:09 PM, Hong Xu <hong@topbug.net> wrote:
>>
>> Bob Copeland <me@bobcopeland.com> writes:
>>
>>> On Sun, Jan 11, 2015 at 01:20:29AM -0800, Hong Xu wrote:
>>>> Add an option "blink" to enable or disable the LED blink. The default
>>>> value is set to 1 so that existing users would not experience any
>>>> unexpected changes.
>>>
>>> Been a while since I looked, but isn't there a way to achieve same
>>> result by just echoing 'none' into the relevant LED's sysfs file
>>> (something like /sys/class/leds/phy0-led/trigger)?
>>
>> It's a bit different. echo 'none' to the trigger would cause the LED
>> light to be dark, but if turn off the blink option here, the LED is
>> bright but without blinking.
>>
>> Hong
>
> I.e. it doesn't blink, it's just on when linked (isn't there a trigger
> for that?) or is on solid? (echo 255 >
> /sys/class/leds/phy0-led/brightness)

It is solid on, but will be off if you turn off wifi (which echo 255 >
/.../brightness will not do). Replace ieee80211_get_radio_led_name with
ieee80211_get_assoc_led_name will use the linking trigger. I think using
linking makes more sense.

Hong

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]