From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:44072 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbaI2GZH (ORCPT ); Mon, 29 Sep 2014 02:25:07 -0400 From: Kalle Valo To: Sujith Manoharan CC: John Linville , , Subject: Re: [PATCH v2] ath: Add support for tracing References: <1411804665-6954-1-git-send-email-sujith@msujith.org> Date: Mon, 29 Sep 2014 09:25:00 +0300 In-Reply-To: <1411804665-6954-1-git-send-email-sujith@msujith.org> (Sujith Manoharan's message of "Sat, 27 Sep 2014 13:27:45 +0530") Message-ID: <87vbo72bb7.fsf@kamboji.qca.qualcomm.com> (sfid-20140929_082512_828365_765FCA79) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Sujith Manoharan writes: > From: Sujith Manoharan > > Signed-off-by: Sujith Manoharan > --- > drivers/net/wireless/ath/Kconfig | 8 +++++ > drivers/net/wireless/ath/Makefile | 4 +++ > drivers/net/wireless/ath/ath.h | 1 + > drivers/net/wireless/ath/main.c | 3 ++ > drivers/net/wireless/ath/trace.c | 20 +++++++++++ > drivers/net/wireless/ath/trace.h | 71 +++++++++++++++++++++++++++++++++++++++ Why add it to ath.ko module? What drivers are going to use this? Because all ath* drivers are different, I suspect there is not that much to share between drivers and that's why it would be better to have the trace points per driver. And I just checked that currently we have trace points for ath10k, ath5k, ath6kl and wil6210. IMHO adding more trace points to ath.ko just makes this confusing. -- Kalle Valo