From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]:63952 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750745AbaFGNDj (ORCPT ); Sat, 7 Jun 2014 09:03:39 -0400 From: Kalle Valo To: Ben Greear CC: Emmanuel Grumbach , ath10k , "linux-wireless@vger.kernel.org" Subject: Re: Firmware debugging patches? References: <53891ACD.7070902@candelatech.com> <87wqczz3h9.fsf@kamboji.qca.qualcomm.com> <538CA904.4000508@candelatech.com> <87ioojz1b1.fsf@kamboji.qca.qualcomm.com> <538CB782.1000509@candelatech.com> <538CC68C.10808@gmail.com> <538CC949.5020901@candelatech.com> <538CD507.1050803@candelatech.com> <87bnu7pqe2.fsf@kamboji.qca.qualcomm.com> <53909372.1040707@candelatech.com> <87fvjimsxj.fsf@kamboji.qca.qualcomm.com> <5391E620.4090706@candelatech.com> Date: Sat, 7 Jun 2014 16:03:31 +0300 In-Reply-To: <5391E620.4090706@candelatech.com> (Ben Greear's message of "Fri, 6 Jun 2014 09:02:40 -0700") Message-ID: <87vbscj2ho.fsf@kamboji.qca.qualcomm.com> (sfid-20140607_150449_821368_FDB40B6A) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Ben Greear writes: > On 06/05/2014 11:51 PM, Kalle Valo wrote: >> Ben Greear writes: >> >>>> Why do you want to put the crash dump in kernel log, can you describe >>>> your "use case" here? For me it would be enough to have a UUID for each >>>> crash dump and then have the driver print that to kernel log: >>>> >>>> ath10k: firmware crashed (uuid 1234567890-4321) >>>> >>>> And then you just need to find the correct dump from the file system and >>>> start debugging. Would that be enough for you? >>> >>> Not all systems will have fancy user-space able to deal with this. >>> >>> At the very least, please leave in the current firmware crash >>> dump text. >> >> I'm not removing anything. That was just an example how we can identify >> crashes. > > Perhaps the time-stamp is good enough? I don't see a need for > a uuid, but perhaps I am missing something? UUID is supposed to be unique. If we use walltime there's no guarantee that the clock is correct and if we use local_clock() (my preference) it will be reset after every boot. I just think using something like UUID is more robust. Especially if one implements an automatic crash dump collector from thousands of deployed APs, having an UUID makes it a lot easier to manage. -- Kalle Valo