From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 3/3] ath10k: implement firmware IE container support
Date: Thu, 26 Sep 2013 09:18:05 +0300 [thread overview]
Message-ID: <87vc1ot8bm.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=v0snRLTP44LXVdQx2UVKYxLCW-JiWyMWOR4eEzMvFKA@mail.gmail.com> (Michal Kazior's message of "Thu, 26 Sep 2013 08:04:39 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 26 September 2013 07:55, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> Did you skip board file intentionally?
>>
>> Yes, because my understanding is that the board file is not tied to any
>> particular firmware version. The board file should be specific to the
>> hardware configuration in use, or at least that's how it is with ath6kl.
>
> But the board file is not loaded at all for API 2. The api_1 variant
> requests 3 files and can result with up to 3 binaries loaded. api_n
> requests 1 file and can result with up to 2 binaries loaded.
Oops, that's clearly a bug. How did it even pass my tests without the
board file? I'll send v2 to fix that.
So my idea is that with API 2 we load only firmware-2.bin and board.bin
from user space. With API 1 we continue loading firmware.bin, otp.bin
(optional) and board.bin, just as before. And firmware-2.bin can contain
the old firmware.bin (mandatory) and otp.bin (optional) images.
I just realised that I'm missing a check that there really is a firmware
image inside firmware-2.bin, need to add that as well.
--
Kalle Valo
prev parent reply other threads:[~2013-09-26 6:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 21:08 [PATCH 0/3] ath10k: implement FW IE support Kalle Valo
2013-09-25 21:08 ` [PATCH 1/3] ath10k: rename board_data in struct ath10k Kalle Valo
2013-09-25 21:08 ` [PATCH 2/3] ath10k: store separate pointers for firmware data Kalle Valo
2013-09-25 21:08 ` [PATCH 3/3] ath10k: implement firmware IE container support Kalle Valo
2013-09-26 5:46 ` Michal Kazior
2013-09-26 5:55 ` Kalle Valo
2013-09-26 6:04 ` Michal Kazior
2013-09-26 6:18 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vc1ot8bm.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox