From: Kalle Valo <kvalo@adurom.com>
To: Stanislaw Gruszka <sgruszka@redhat.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Greg Dietsche <gregory.dietsche@cuw.edu>,
linux-wireless@vger.kernel.org
Subject: Re: pull request: iwlegacy 2011-11-16
Date: Mon, 21 Nov 2011 17:32:59 +0200 [thread overview]
Message-ID: <87vcqdij84.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20111118073041.GA2203@redhat.com> (Stanislaw Gruszka's message of "Fri, 18 Nov 2011 08:30:42 +0100")
Stanislaw Gruszka <sgruszka@redhat.com> writes:
> On Thu, Nov 17, 2011 at 02:03:08PM -0500, John W. Linville wrote:
>> On Thu, Nov 17, 2011 at 09:36:44AM +0200, Kalle Valo wrote:
>> > Stanislaw Gruszka <sgruszka@redhat.com> writes:
>>
>> > I haven't seen these patches on linux-wireless mailing list at all.
>
> I did not post them because most of them are big patches done by sed or
> "git mv", nothing that would benefit from review.
If you use git's rename detection patches moving files shouldn't be
large. And besides, if you are doing so big changes that patches are too
big for the mailing list I think you are doing something wrong.
> Anyway, if someone like to look at the patches, its better to just pull
> github tree, or even clone it. It used with --reference option clone
> will be fast, i.e:
>
> git clone --reference linux-2.6 git://github.com/sgruszka/iwlegacy.git
Nobody is going to do review from a git tree unless forced. That's why
we review via email.
--
Kalle Valo
prev parent reply other threads:[~2011-11-21 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 12:22 pull request: iwlegacy 2011-11-16 Stanislaw Gruszka
2011-11-17 7:36 ` Kalle Valo
2011-11-17 19:03 ` John W. Linville
2011-11-18 7:30 ` Stanislaw Gruszka
2011-11-21 15:32 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vcqdij84.fsf@purkki.adurom.net \
--to=kvalo@adurom.com \
--cc=gregory.dietsche@cuw.edu \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=sgruszka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).