From: Kalle Valo <kalle.valo@iki.fi>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: linux-wireless@vger.kernel.org, Bob Copeland <me@bobcopeland.com>
Subject: Re: [PATCH 2/4] wl1251: fix ELP_CTRL register accesses when using SDIO
Date: Fri, 12 Mar 2010 08:36:01 +0200 [thread overview]
Message-ID: <87vdd2cai6.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1268322297-16667-1-git-send-email-notasas@gmail.com> (Grazvydas Ignotas's message of "Thu\, 11 Mar 2010 17\:44\:57 +0200")
Grazvydas Ignotas <notasas@gmail.com> writes:
> For some unknown reason ELP_CTRL can't be accesed using
> sdio_memcpy_* functions (any attemts to do so result in timeouts):
>
> wl1251: ERROR sdio write failed (-110)
> wl1251: ERROR sdio read failed (-110)
> wl1251: WARNING WLAN not ready
Yes, this is needed. A separate SDIO command is needed to wakeup the
chip from sleep.
> To fix this, add special IO functions for ELP_CTRL access that are
> using sdio_readb/sdio_writeb. Similar handling is done in TI
> reference driver from Android code drop.
Also wl1271 should behave similarly in this respect.
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> Cc: Bob Copeland <me@bobcopeland.com>
Thanks, looks good.
Acked-by: Kalle Valo <kalle.valo@iki.fi>
--
Kalle Valo
prev parent reply other threads:[~2010-03-12 6:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 15:44 [PATCH 2/4] wl1251: fix ELP_CTRL register accesses when using SDIO Grazvydas Ignotas
2010-03-12 6:36 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdd2cai6.fsf@purkki.valot.fi \
--to=kalle.valo@iki.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=me@bobcopeland.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).