From: Kalle Valo <kalle.valo@nokia.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Jouni Malinen <j@w1.fi>
Subject: Re: [RFC PATCH v2 2/4] mac80211: track beacons separately from the rx path activity
Date: Sun, 15 Mar 2009 08:52:15 +0200 [thread overview]
Message-ID: <87vdqb1dnk.fsf@nokia.com> (raw)
In-Reply-To: <43e72e890903141245k46f4dd4co6a33b45b82e9098a@mail.gmail.com> (ext Luis R. Rodriguez's message of "Sat\, 14 Mar 2009 20\:45\:12 +0100")
"Luis R. Rodriguez" <lrodriguez@atheros.com> writes:
> On Sat, Mar 14, 2009 at 10:14 AM, Kalle Valo <kalle.valo@nokia.com> wrote:
>> Separate beacon and rx path tracking in preparation for the beacon filtering
>> support. At the same time change ieee80211_associated() to look a bit simpler.
>>
>> Probe requests are now sent only after IEEE80211_PROBE_IDLE_TIME, which
>> is now set to 60 seconds.
>>
>> Signed-off-by: Kalle Valo <kalle.valo@nokia.com>
>
> Can this be split into 3 separate patches, to make the one with the
> actual functional changes easier to review. One is the making of
> ieee80211_associated() look easier, the other the rename, and lastly
> the actual functional changes. When reviewing the commit log it would
> then be easier to see what was done.
Is it really worth the trouble? The patch is relatively small so
spotting the changes shouldn't be that difficult.
--
Kalle Valo
next prev parent reply other threads:[~2009-03-15 6:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 17:14 [RFC PATCH v2 0/4] mac80211: beacon filtering Kalle Valo
2009-03-14 17:14 ` [RFC PATCH v2 1/4] mac80211: decrease execution of the associated timer Kalle Valo
2009-03-14 17:18 ` Johannes Berg
2009-03-14 18:46 ` Kalle Valo
2009-03-14 19:33 ` Luis R. Rodriguez
2009-03-20 9:22 ` Kalle Valo
2009-03-20 9:42 ` Johannes Berg
2009-03-20 10:37 ` Kalle Valo
2009-03-20 10:41 ` Johannes Berg
2009-03-14 17:14 ` [RFC PATCH v2 2/4] mac80211: track beacons separately from the rx path activity Kalle Valo
2009-03-14 17:21 ` Johannes Berg
2009-03-14 19:45 ` Luis R. Rodriguez
2009-03-14 19:55 ` Johannes Berg
2009-03-14 20:19 ` Luis R. Rodriguez
2009-03-15 6:52 ` Kalle Valo [this message]
2009-03-14 17:14 ` [RFC PATCH v2 3/4] mac80211: disable power save when scanning Kalle Valo
2009-03-14 17:25 ` Johannes Berg
2009-03-14 17:37 ` Kalle Valo
2009-03-14 17:14 ` [RFC PATCH v2 4/4] mac80211: add beacon filtering support Kalle Valo
2009-03-14 17:28 ` Johannes Berg
2009-03-14 17:55 ` Kalle Valo
2009-03-14 20:18 ` Luis R. Rodriguez
2009-03-15 7:22 ` Kalle Valo
2009-03-15 17:59 ` Johannes Berg
2009-03-15 19:27 ` Luis R. Rodriguez
2009-03-15 20:10 ` Kalle Valo
2009-03-16 8:50 ` Jouni Malinen
2009-03-16 12:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdqb1dnk.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).