From: Kalle Valo <kalle.valo@nokia.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC PATCH v4 1/5] mac80211: enable IEEE80211_CONF_PS only when associated
Date: Fri, 05 Dec 2008 07:47:02 +0200 [thread overview]
Message-ID: <87vdtzi36x.fsf@nokia.com> (raw)
In-Reply-To: <1228411658.5692.19.camel@johannes.berg> (ext Johannes Berg's message of "Thu\, 04 Dec 2008 18\:27\:38 +0100")
Johannes Berg <johannes@sipsolutions.net> writes:
> On Tue, 2008-12-02 at 22:03 +0200, Kalle Valo wrote:
>
>> - return ieee80211_hw_config(local, IEEE80211_CONF_CHANGE_PS);
>> + if (ps == local->powersave)
>> + return ret;
>> +
>> +set:
>> + local->powersave = ps;
>> +
>> + if (sdata->vif.type != NL80211_IFTYPE_STATION)
>> + return ret;
>
> Shouldn't that test be earlier? There's little sense in supporting PS if
> you have a non-STA interface.
I'll move the test.
> In fact, it might make sense to check that there's no other
> interface (except monitor) open?
I'll add this check as well.
Thank you for the comments.
--
Kalle Valo
next prev parent reply other threads:[~2008-12-05 5:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-02 20:03 [RFC PATCH v4 0/5] mac80211 dynamic power save Kalle Valo
2008-12-02 20:03 ` [RFC PATCH v4 1/5] mac80211: enable IEEE80211_CONF_PS only when associated Kalle Valo
2008-12-04 17:27 ` Johannes Berg
2008-12-05 5:47 ` Kalle Valo [this message]
2008-12-05 9:40 ` Johannes Berg
2008-12-02 20:04 ` [RFC PATCH v4 2/5] mac80211: implement dynamic power save Kalle Valo
2008-12-02 20:04 ` [RFC PATCH v4 3/5] mac80211: add IEEE80211_HW_NO_DYNAMIC_PS flag Kalle Valo
2008-12-02 20:04 ` [RFC PATCH v4 4/5] mac80211: move dynamic_ps_timeout to hw.conf Kalle Valo
2008-12-02 20:04 ` [RFC PATCH v4 5/5] mac80211: track master queue status Kalle Valo
2008-12-04 17:34 ` Johannes Berg
2008-12-05 5:51 ` Kalle Valo
2008-12-05 9:41 ` Johannes Berg
2008-12-05 9:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vdtzi36x.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).