From: Kalle Valo <kvalo@kernel.org>
To: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
Cc: <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/3] wifi: ath12k: Refactor the monitor Tx/RX handler procedure arguments
Date: Thu, 19 Dec 2024 13:32:06 +0200 [thread overview]
Message-ID: <87wmfvj4cp.fsf@kernel.org> (raw)
In-Reply-To: <20241219001006.1036495-3-quic_periyasa@quicinc.com> (Karthikeyan Periyasamy's message of "Thu, 19 Dec 2024 05:40:05 +0530")
Karthikeyan Periyasamy <quic_periyasa@quicinc.com> writes:
> Currently, the pdev handle is given along with the mac id to all the
> monitor Tx/Rx handler procedure arguments. The mac id information is
> derived from the pdev handle itself. Therefore, remove the unnecessary
> mac id argument from the handler.
>
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1
> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
>
> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com>
> ---
> drivers/net/wireless/ath/ath12k/dp_mon.c | 29 ++++++++++++------------
> drivers/net/wireless/ath/ath12k/dp_mon.h | 7 +++---
> 2 files changed, 17 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/dp_mon.c b/drivers/net/wireless/ath/ath12k/dp_mon.c
> index 85ff89b91624..ae2f6847bc88 100644
> --- a/drivers/net/wireless/ath/ath12k/dp_mon.c
> +++ b/drivers/net/wireless/ath/ath12k/dp_mon.c
> @@ -845,7 +845,7 @@ static void ath12k_dp_mon_rx_msdus_set_payload(struct ath12k *ar,
> }
>
> static struct sk_buff *
> -ath12k_dp_mon_rx_merg_msdus(struct ath12k *ar, u32 mac_id,
> +ath12k_dp_mon_rx_merg_msdus(struct ath12k *ar,
BTW I find it confusing that in the commit message you talk about "pdev
handle" but in the code it's named "ar". It would be nice to have
terminology all over. No need to change anything for this patch, just a
small comment for the future.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-12-19 11:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 0:10 [PATCH 0/3] wifi: ath12k: Refactor monitor Rx handler Karthikeyan Periyasamy
2024-12-19 0:10 ` [PATCH 1/3] wifi: ath12k: Refactor the monitor Rx parser handler argument Karthikeyan Periyasamy
2024-12-19 11:27 ` Kalle Valo
2024-12-19 0:10 ` [PATCH 2/3] wifi: ath12k: Refactor the monitor Tx/RX handler procedure arguments Karthikeyan Periyasamy
2024-12-19 11:32 ` Kalle Valo [this message]
2024-12-19 11:35 ` Kalle Valo
2024-12-19 0:10 ` [PATCH 3/3] wifi: ath12k: Refactor Rx status TLV parsing procedure argument Karthikeyan Periyasamy
2024-12-19 11:34 ` Kalle Valo
2024-12-19 11:42 ` Karthikeyan Periyasamy
2024-12-19 18:54 ` Kalle Valo
2024-12-20 0:26 ` Karthikeyan Periyasamy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmfvj4cp.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_periyasa@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox