* [PATCH -next] mac80211: remove redundant unlikely() around IS_ERR()
@ 2024-08-23 2:37 Zhang Changzhong
2024-08-23 9:02 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Changzhong @ 2024-08-23 2:37 UTC (permalink / raw)
To: linux-wireless; +Cc: Zhang Changzhong, Johannes Berg
IS_ERR() already calls unlikely(), so unlikely() is redundant here.
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
net/mac80211/mesh_pathtbl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mac80211/mesh_pathtbl.c b/net/mac80211/mesh_pathtbl.c
index c0a5c75..30c0d89 100644
--- a/net/mac80211/mesh_pathtbl.c
+++ b/net/mac80211/mesh_pathtbl.c
@@ -580,7 +580,7 @@ void mesh_fast_tx_cache(struct ieee80211_sub_if_data *sdata,
prev = rhashtable_lookup_get_insert_fast(&cache->rht,
&entry->rhash,
fast_tx_rht_params);
- if (unlikely(IS_ERR(prev))) {
+ if (IS_ERR(prev)) {
kfree(entry);
goto unlock_cache;
}
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] mac80211: remove redundant unlikely() around IS_ERR()
2024-08-23 2:37 [PATCH -next] mac80211: remove redundant unlikely() around IS_ERR() Zhang Changzhong
@ 2024-08-23 9:02 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2024-08-23 9:02 UTC (permalink / raw)
To: Zhang Changzhong; +Cc: linux-wireless, Johannes Berg
Zhang Changzhong <zhangchangzhong@huawei.com> writes:
> IS_ERR() already calls unlikely(), so unlikely() is redundant here.
>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
"wifi:" missing in the title.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-23 9:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-23 2:37 [PATCH -next] mac80211: remove redundant unlikely() around IS_ERR() Zhang Changzhong
2024-08-23 9:02 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).