From: Kalle Valo <kvalo@kernel.org>
To: Ma Ke <make24@iscas.ac.cn>
Cc: dan.carpenter@linaro.org, benjamin.berg@intel.com,
daniel.gabay@intel.com, gregory.greenman@intel.com,
johannes.berg@intel.com, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org,
miriam.rachel.korenblit@intel.com
Subject: Re: [PATCH RESEND] wifi: iwlwifi: mvm: fix an error code in iwl_mvm_alloc_sta_after_restart()
Date: Fri, 23 Aug 2024 08:56:11 +0300 [thread overview]
Message-ID: <87wmk7vl38.fsf@kernel.org> (raw)
In-Reply-To: <20240823030423.1781977-1-make24@iscas.ac.cn> (Ma Ke's message of "Fri, 23 Aug 2024 11:04:23 +0800")
Ma Ke <make24@iscas.ac.cn> writes:
> Dan Carpenter<dan.carpenter@linaro.org> wrote:.
>> The Subject says RESEND but doesn't explain why you are resending..
>> You probably meant v2, but again it needs an explanation..
>> .
>> On Fri, Aug 02, 2024 at 12:27:40PM +0800, Ma Ke wrote:.
>> > This error path should return -EINVAL instead of success..
>> .
>> Why do you feel that way? Have you tested it? What is the user visible.
>> effect of this bug?.
>> .
>> I slightly feel hypocritical because I have send lots of commit messages.
>> with exactly this commit message. The difference is that I only send.
>> really easy patches where it's obvious what the intent was. A normal.
>> kernel developer wouldn't need to leave their email client or view any.
>> outside information to see that my patch is correct. If a patch is not.
>> dead easy, I normally just report it. (Sometimes I report dead easy.
>> bugs as well because I am lazy and maybe it's the end of my work day.
>> or whatever)..
>> .
>> This patch on the other hand is more subtle and it's not clear why the.
>> continue statements changed into returns..
>> .
>> regards,.
>> dan carpenter.
> Thank you for your response to the vulnerability I submitted. Yes, we .
> believe there is a similar issue. As described in [1], it gets pointers .
> which are handled under the protection mechanism. If the path is error, it .
> should return -EINVAL directly instead of success.
The commit message should explain _why_ it should return an error.
Currently there's no explanation neither in the commit message or in
your email.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
https://docs.kernel.org/process/submitting-patches.html
next prev parent reply other threads:[~2024-08-23 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 4:27 [PATCH RESEND] wifi: iwlwifi: mvm: fix an error code in iwl_mvm_alloc_sta_after_restart() Ma Ke
2024-08-02 5:09 ` Dan Carpenter
2024-08-23 3:04 ` Ma Ke
2024-08-23 5:56 ` Kalle Valo [this message]
2024-08-23 9:03 ` Dan Carpenter
2024-08-23 9:14 ` Dan Carpenter
2024-08-23 9:29 ` Berg, Benjamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmk7vl38.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=benjamin.berg@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel.gabay@intel.com \
--cc=gregory.greenman@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=make24@iscas.ac.cn \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).