From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "lkp@intel.com" <lkp@intel.com>,
"linux-wireless@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"oe-kbuild-all@lists.linux.dev" <oe-kbuild-all@lists.linux.dev>
Subject: Re: [PATCH 3/4] wifi: rtw89: fw: parse secure section from firmware file
Date: Mon, 05 Feb 2024 08:47:04 +0200 [thread overview]
Message-ID: <87wmrjs907.fsf@kernel.org> (raw)
In-Reply-To: <e645b875c771216f688ae106abd5be86aff59b42.camel@realtek.com> (Ping-Ke Shih's message of "Sun, 4 Feb 2024 01:31:45 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
> On Sun, 2024-02-04 at 03:22 +0800, kernel test robot wrote:
>>
>> drivers/net/wireless/realtek/rtw89/fw.c: In function 'rtw89_fw_hdr_parser_v1':
>> > > drivers/net/wireless/realtek/rtw89/fw.c:384:88: warning: format
>> > > '%lx' expects argument of type
>> > > 'long unsigned int', but argument 9 has type 'int' [-Wformat=]
>> 384 | "section[%d] type=%d len=0x%-6x mssc=%d mssc_len=%d
>> addr=%lx\n",
>> | ~~
>> ^
>> |
>> |
>> |
>> long unsigned int
>> | %x
>> 385 | i, section_info->type, section_info->len,
>> 386 | section_info->mssc, mssc_len, bin - fw);
>> | ~~~~~~~~
>> | |
>> | int
>
> I looked for how to print out differences (subtraction) of points, and
> "%tx" is the desired format [1]. I corrected this by v2.
>
> [1] https://docs.kernel.org/core-api/printk-formats.html#pointer-differences
Heh, never heard of %td and %tx before. Thanks for teaching us :)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-02-05 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-03 0:32 [PATCH 0/4] wifi: rtw89: fw: support firmware secure boot Ping-Ke Shih
2024-02-03 0:32 ` [PATCH 1/4] wifi: rtw89: fw: consider checksum length of security data Ping-Ke Shih
2024-02-03 0:32 ` [PATCH 2/4] wifi: rtw89: fw: read firmware secure information from efuse Ping-Ke Shih
2024-02-03 0:32 ` [PATCH 3/4] wifi: rtw89: fw: parse secure section from firmware file Ping-Ke Shih
2024-02-03 19:22 ` kernel test robot
2024-02-04 1:31 ` Ping-Ke Shih
2024-02-05 6:47 ` Kalle Valo [this message]
2024-02-03 0:32 ` [PATCH 4/4] wifi: rtw89: fw: download firmware with key data for secure boot Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wmrjs907.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).