* [PATCH] mt76: address4 null frame using fixed rate to trigger WDS
@ 2022-07-06 9:09 Lian Chen
2022-07-06 13:01 ` Felix Fietkau
2022-07-26 13:06 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Lian Chen @ 2022-07-06 9:09 UTC (permalink / raw)
To: Felix Fietkau
Cc: linux-wireless, Bo Jiao, Sujuan Chen, Shayne Chen, Evelyn Tsai,
Lian Chen, linux-mediatek
From: "lian.chen" <lian.chen@mediatek.com>
WDS function need address4 package to trigger the AP create wlan0.sta.
while the address4 null frame is sent at a high rate.
the AP can not receive it.
so, using fixed rate to trigger WDS flow.
Signed-off-by: lian.chen <lian.chen@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c b/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c
index 3ab0dcd..d83ed59 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76_connac_mac.c
@@ -393,7 +393,8 @@ mt76_connac2_mac_write_txwi_80211(struct mt76_dev *dev, __le32 *txwi,
}
if (!ieee80211_is_data(fc) || multicast ||
- info->flags & IEEE80211_TX_CTL_USE_MINRATE)
+ info->flags & IEEE80211_TX_CTL_USE_MINRATE ||
+ (ieee80211_is_nullfunc(fc) && ieee80211_has_a4(fc)))
val |= MT_TXD2_FIX_RATE;
txwi[2] |= cpu_to_le32(val);
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76: address4 null frame using fixed rate to trigger WDS
2022-07-06 9:09 [PATCH] mt76: address4 null frame using fixed rate to trigger WDS Lian Chen
@ 2022-07-06 13:01 ` Felix Fietkau
2022-07-26 13:06 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Felix Fietkau @ 2022-07-06 13:01 UTC (permalink / raw)
To: Lian Chen
Cc: linux-wireless, Bo Jiao, Sujuan Chen, Shayne Chen, Evelyn Tsai,
linux-mediatek
On 06.07.22 11:09, Lian Chen wrote:
> From: "lian.chen" <lian.chen@mediatek.com>
>
> WDS function need address4 package to trigger the AP create wlan0.sta.
> while the address4 null frame is sent at a high rate.
> the AP can not receive it.
> so, using fixed rate to trigger WDS flow.
>
> Signed-off-by: lian.chen <lian.chen@mediatek.com>
I think it might make more sense to set IEEE80211_TX_CTL_USE_MINRATE in
the mac80211 function ieee80211_send_4addr_nullfunc().
- Felix
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mt76: address4 null frame using fixed rate to trigger WDS
2022-07-06 9:09 [PATCH] mt76: address4 null frame using fixed rate to trigger WDS Lian Chen
2022-07-06 13:01 ` Felix Fietkau
@ 2022-07-26 13:06 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2022-07-26 13:06 UTC (permalink / raw)
To: Lian Chen
Cc: Felix Fietkau, linux-wireless, Bo Jiao, Sujuan Chen, Shayne Chen,
Evelyn Tsai, linux-mediatek
Lian Chen <lian.chen@mediatek.com> writes:
> From: "lian.chen" <lian.chen@mediatek.com>
Please don't use dot in your name and capitalise it as well. So this
should be:
From: "Lian Chen" <lian.chen@mediatek.com>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-26 13:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-06 9:09 [PATCH] mt76: address4 null frame using fixed rate to trigger WDS Lian Chen
2022-07-06 13:01 ` Felix Fietkau
2022-07-26 13:06 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).