* [PATCH] mt76: fix timestamp check in tx_status
@ 2021-11-22 15:10 Deren Wu
2021-11-22 16:00 ` Felix Fietkau
2021-11-24 17:21 ` Kalle Valo
0 siblings, 2 replies; 4+ messages in thread
From: Deren Wu @ 2021-11-22 15:10 UTC (permalink / raw)
To: Felix Fietkau, Lorenzo Bianconi
Cc: Sean Wang, Soul Huang, YN Chen, Leon Yen, Eric-SY Chang, Deren Wu,
KM Lin, Robin Chiu, CH Yeh, Posh Sun, Eric Liang, Stella Chang,
Evelyn Tsai, Ryder Lee, Shayne Chen, linux-wireless,
linux-mediatek, Deren Wu
From: Deren Wu <deren.wu@mediatek.com>
Should keep SKBs only if timeout timestamp is still after jiffies.
Otherwise, report tx status and drop it direclty.
Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
Signed-off-by: Deren Wu <deren.wu@mediatek.com>
---
drivers/net/wireless/mediatek/mt76/tx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/tx.c b/drivers/net/wireless/mediatek/mt76/tx.c
index 11719ef034d8..6b8c9dc80542 100644
--- a/drivers/net/wireless/mediatek/mt76/tx.c
+++ b/drivers/net/wireless/mediatek/mt76/tx.c
@@ -173,7 +173,7 @@ mt76_tx_status_skb_get(struct mt76_dev *dev, struct mt76_wcid *wcid, int pktid,
if (!(cb->flags & MT_TX_CB_DMA_DONE))
continue;
- if (!time_is_after_jiffies(cb->jiffies +
+ if (time_is_after_jiffies(cb->jiffies +
MT_TX_STATUS_SKB_TIMEOUT))
continue;
}
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] mt76: fix timestamp check in tx_status
2021-11-22 15:10 [PATCH] mt76: fix timestamp check in tx_status Deren Wu
@ 2021-11-22 16:00 ` Felix Fietkau
2021-11-22 18:24 ` Kalle Valo
2021-11-24 17:21 ` Kalle Valo
1 sibling, 1 reply; 4+ messages in thread
From: Felix Fietkau @ 2021-11-22 16:00 UTC (permalink / raw)
To: Deren Wu, Lorenzo Bianconi
Cc: Sean Wang, Soul Huang, YN Chen, Leon Yen, Eric-SY Chang, KM Lin,
Robin Chiu, CH Yeh, Posh Sun, Eric Liang, Stella Chang,
Evelyn Tsai, Ryder Lee, Shayne Chen, linux-wireless,
linux-mediatek, Kalle Valo
On 2021-11-22 16:10, Deren Wu wrote:
> From: Deren Wu <deren.wu@mediatek.com>
>
> Should keep SKBs only if timeout timestamp is still after jiffies.
> Otherwise, report tx status and drop it direclty.
>
> Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
> Signed-off-by: Deren Wu <deren.wu@mediatek.com>
Acked-by: Felix Fietkau <nbd@nbd.name>
Kalle, please queue this for 5.16
- Felix
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mt76: fix timestamp check in tx_status
2021-11-22 16:00 ` Felix Fietkau
@ 2021-11-22 18:24 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-11-22 18:24 UTC (permalink / raw)
To: Felix Fietkau
Cc: Deren Wu, Lorenzo Bianconi, Sean Wang, Soul Huang, YN Chen,
Leon Yen, Eric-SY Chang, KM Lin, Robin Chiu, CH Yeh, Posh Sun,
Eric Liang, Stella Chang, Evelyn Tsai, Ryder Lee, Shayne Chen,
linux-wireless, linux-mediatek
Felix Fietkau <nbd@nbd.name> writes:
> On 2021-11-22 16:10, Deren Wu wrote:
>> From: Deren Wu <deren.wu@mediatek.com>
>>
>> Should keep SKBs only if timeout timestamp is still after jiffies.
>> Otherwise, report tx status and drop it direclty.
>>
>> Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
>> Signed-off-by: Deren Wu <deren.wu@mediatek.com>
>
> Acked-by: Felix Fietkau <nbd@nbd.name>
>
> Kalle, please queue this for 5.16
Ok, assigned the patch to me on patchwork.
(A feature request for patchwork devs: assign patches based on email
commands)
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mt76: fix timestamp check in tx_status
2021-11-22 15:10 [PATCH] mt76: fix timestamp check in tx_status Deren Wu
2021-11-22 16:00 ` Felix Fietkau
@ 2021-11-24 17:21 ` Kalle Valo
1 sibling, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2021-11-24 17:21 UTC (permalink / raw)
To: Deren Wu
Cc: Felix Fietkau, Lorenzo Bianconi, Sean Wang, Soul Huang, YN Chen,
Leon Yen, Eric-SY Chang, Deren Wu, KM Lin, Robin Chiu, CH Yeh,
Posh Sun, Eric Liang, Stella Chang, Evelyn Tsai, Ryder Lee,
Shayne Chen, linux-wireless, linux-mediatek, Deren Wu
Deren Wu <Deren.Wu@mediatek.com> wrote:
> From: Deren Wu <deren.wu@mediatek.com>
>
> Should keep SKBs only if timeout timestamp is still after jiffies.
> Otherwise, report tx status and drop it direclty.
>
> Fixes: bd1e3e7b693c ("mt76: introduce packet_id idr")
> Signed-off-by: Deren Wu <deren.wu@mediatek.com>
> Acked-by: Felix Fietkau <nbd@nbd.name>
Patch applied to wireless-drivers.git, thanks.
ebb75b1b43d3 mt76: fix timestamp check in tx_status
--
https://patchwork.kernel.org/project/linux-wireless/patch/7e3784949c0b29a00465966b89fdb0192bd0298e.1637593492.git.deren.wu@mediatek.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-24 17:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-22 15:10 [PATCH] mt76: fix timestamp check in tx_status Deren Wu
2021-11-22 16:00 ` Felix Fietkau
2021-11-22 18:24 ` Kalle Valo
2021-11-24 17:21 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).