From: Kalle Valo <kvalo@codeaurora.org>
To: P Praneesh <ppranees@codeaurora.org>
Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
Sriram R <srirrama@codeaurora.org>,
Jouni Malinen <jouni@codeaurora.org>
Subject: Re: [PATCH v3 03/12] ath11k: modify dp_rx desc access wrapper calls inline
Date: Fri, 12 Nov 2021 10:35:30 +0200 [thread overview]
Message-ID: <87wnldixf1.fsf@codeaurora.org> (raw)
In-Reply-To: <1630560820-21905-4-git-send-email-ppranees@codeaurora.org> (P. Praneesh's message of "Thu, 2 Sep 2021 11:03:31 +0530")
P Praneesh <ppranees@codeaurora.org> writes:
> In data path, to reduce the CPU cycles spending on descriptor access
> wrapper function, changed those functions as static inline.
>
> Tested-on: QCN9074 hw1.0 PCI WLAN.HK.2.4.0.1.r2-00012-QCAHKSWPL_SILICONZ-1
> Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.4.0.1-01695-QCAHKSWPL_SILICONZ-1
>
> Co-developed-by: Sriram R <srirrama@codeaurora.org>
> Signed-off-by: Sriram R <srirrama@codeaurora.org>
> Signed-off-by: Jouni Malinen <jouni@codeaurora.org>
> Signed-off-by: P Praneesh <ppranees@codeaurora.org>
> ---
> drivers/net/wireless/ath/ath11k/dp_rx.c | 114 +++++++++++++++++---------------
> 1 file changed, 59 insertions(+), 55 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
> index 9a22481..b84c2db 100644
> --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
> +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
> @@ -20,13 +20,15 @@
>
> #define ATH11K_DP_RX_FRAGMENT_TIMEOUT_MS (2 * HZ)
>
> -static u8 *ath11k_dp_rx_h_80211_hdr(struct ath11k_base *ab, struct hal_rx_desc *desc)
> +static inline
> +u8 *ath11k_dp_rx_h_80211_hdr(struct ath11k_base *ab, struct hal_rx_desc *desc)
> {
> return ab->hw_params.hw_ops->rx_desc_get_hdr_status(desc);
> }
The compiler does not optimise small static functions like this
automatically to inline? I'm surprised. Or are you using some really old
compiler?
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-11-12 8:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 5:33 [PATCH v3 00/12] ath11k: optimizations in data path P Praneesh
2021-09-02 5:33 ` [PATCH v3 01/12] ath11k: disable unused CE8 interrupts for ipq8074 P Praneesh
2021-11-15 9:22 ` Kalle Valo
2021-09-02 5:33 ` [PATCH v3 02/12] ath11k: allocate dst ring descriptors from cacheable memory P Praneesh
2021-09-02 5:33 ` [PATCH v3 03/12] ath11k: modify dp_rx desc access wrapper calls inline P Praneesh
2021-11-12 8:35 ` Kalle Valo [this message]
2021-09-02 5:33 ` [PATCH v3 04/12] ath11k: avoid additional access to ath11k_hal_srng_dst_num_free P Praneesh
2021-09-02 5:33 ` [PATCH v3 05/12] ath11k: avoid active pdev check for each msdu P Praneesh
2021-09-02 5:33 ` [PATCH v3 06/12] ath11k: remove usage quota while processing rx packets P Praneesh
2021-09-02 5:33 ` [PATCH v3 07/12] ath11k: add branch predictors in process_rx P Praneesh
2021-09-02 5:33 ` [PATCH v3 08/12] ath11k: allocate HAL_WBM2SW_RELEASE ring from cacheable memory P Praneesh
2021-09-02 5:33 ` [PATCH v3 09/12] ath11k: remove mod operator in dst ring processing P Praneesh
2021-09-02 5:33 ` [PATCH v3 10/12] ath11k: avoid while loop in ring selection of tx completion interrupt P Praneesh
2021-09-02 5:33 ` [PATCH v3 11/12] ath11k: add branch predictors in dp_tx path P Praneesh
2021-09-02 5:33 ` [PATCH v3 12/12] ath11k: avoid unnecessary lock contention in tx_completion path P Praneesh
2021-11-12 13:07 ` [PATCH v3 00/12] ath11k: optimizations in data path Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnldixf1.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=jouni@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ppranees@codeaurora.org \
--cc=srirrama@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).