From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21217C43219 for ; Tue, 30 Apr 2019 09:36:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E465C20835 for ; Tue, 30 Apr 2019 09:36:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="hFw6RRH9"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cPb/0Xp2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbfD3Jgs (ORCPT ); Tue, 30 Apr 2019 05:36:48 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:51352 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726012AbfD3Jgr (ORCPT ); Tue, 30 Apr 2019 05:36:47 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 67C2660DB3; Tue, 30 Apr 2019 09:36:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556617007; bh=lN4glXMpqtmRgarltcSpOuqbmL55CZP7DhJ20iLDeNM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hFw6RRH9cvRt6Mgnppf7kwcJr8CMjQgPNIH9WlC52jE99oi7GXm+zi7XYhVj+U4zW eFOh8bowIsduSiWs5//plfUwEkEiz9gRq1R3zeVgRcK6CdOKtGgvxmQ4iSJ3PpFLJ1 zbivu1qdUIimguEFaY74h8kYvZTiiWCOw1R724Io= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D1E50608D4; Tue, 30 Apr 2019 09:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556617005; bh=lN4glXMpqtmRgarltcSpOuqbmL55CZP7DhJ20iLDeNM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=cPb/0Xp27oPqXfjD1tlSaJTTsy6F58/8EO6bRU1ekuW8GnALHqwmpY8d+xKTmDRRw PgZhSXwiyGf5/kTqiHuD96Uf1jdz1KBoMD0z0d+iVdAMr+khoQRmyhfDmIFJDvW7sH g0T/P8/dsOsTj3KuCGkRVe9lCffLc7deL7nRuWTc= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D1E50608D4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Nicolas Boichat Cc: Wen Gong , Claire Chang , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH] ath10k: add peer id check in ath10k_peer_find_by_id References: <1554260478-4161-1-git-send-email-wgong@codeaurora.org> Date: Tue, 30 Apr 2019 12:36:41 +0300 In-Reply-To: (Nicolas Boichat's message of "Mon, 29 Apr 2019 18:30:00 +0800") Message-ID: <87wojbrg0m.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Nicolas Boichat writes: > On Wed, Apr 3, 2019 at 3:01 AM Wen Gong wrote: >> >> For some SDIO chip, the peer id is 65535 for MPDU with error status, >> then test_bit will trigger buffer overflow for peer's memory, if kasan >> enabled, it will report error. >> >> Add check for overflow the size of peer's peer_ids will avoid the buffer >> overflow access. >> [...] >> --- a/drivers/net/wireless/ath/ath10k/txrx.c >> +++ b/drivers/net/wireless/ath/ath10k/txrx.c >> @@ -157,6 +157,9 @@ struct ath10k_peer *ath10k_peer_find_by_id(struct ath10k *ar, int peer_id) >> { >> struct ath10k_peer *peer; >> >> + if (peer_id >= sizeof(peer->peer_ids) * BITS_PER_BYTE) > > I'd use >= BITS_PER_TYPE(peer->peer_ids). Nice, I didn't know about that. Wen, please submit v2 using this. -- Kalle Valo