From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD2E6C43219 for ; Tue, 30 Apr 2019 12:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E91D2075E for ; Tue, 30 Apr 2019 12:00:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="NXM+1bI7"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="NXM+1bI7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727390AbfD3MAg (ORCPT ); Tue, 30 Apr 2019 08:00:36 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:42096 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727282AbfD3MAf (ORCPT ); Tue, 30 Apr 2019 08:00:35 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id C7B1A60A44; Tue, 30 Apr 2019 12:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556625634; bh=LbqOttWCDNF4UpbUtc7p4YaKq8WmZv2WxQcrvtfdo28=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=NXM+1bI7fQr5eYvjPLT91hjZIbyDlVmFVXKMOQ/ptuIV0rpkGQ2Av3oBtjcd9hbs9 doPvmt69iOeXwPv3O62eWvzpu1npAogUrXDqemsuV8OsJUJl5m7MpjjNdmbC84LyxD kCS3pZ2CLzt6NGFAhm4BpDfSt169PMCO70gKVWdQ= Received: from purkki.adurom.net (purkki.adurom.net [80.68.90.206]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8FB9F6074F; Tue, 30 Apr 2019 12:00:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556625634; bh=LbqOttWCDNF4UpbUtc7p4YaKq8WmZv2WxQcrvtfdo28=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=NXM+1bI7fQr5eYvjPLT91hjZIbyDlVmFVXKMOQ/ptuIV0rpkGQ2Av3oBtjcd9hbs9 doPvmt69iOeXwPv3O62eWvzpu1npAogUrXDqemsuV8OsJUJl5m7MpjjNdmbC84LyxD kCS3pZ2CLzt6NGFAhm4BpDfSt169PMCO70gKVWdQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8FB9F6074F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Cc: , , , , , , , Subject: Re: [PATCH v9 09/14] rtw88: chip files References: <1555653004-1795-1-git-send-email-yhchuang@realtek.com> <1555653004-1795-10-git-send-email-yhchuang@realtek.com> <87d0l3rdpp.fsf@kamboji.qca.qualcomm.com> Date: Tue, 30 Apr 2019 15:00:29 +0300 In-Reply-To: <87d0l3rdpp.fsf@kamboji.qca.qualcomm.com> (Kalle Valo's message of "Tue, 30 Apr 2019 13:26:26 +0300") Message-ID: <87wojbwvmq.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kalle Valo writes: > writes: > >> From: Yan-Hsuan Chuang >> >> chip files Realtek 802.11ac wireless network chips >> 8822B & 8822C series files >> >> Reviewed-by: Stanislaw Gruszka >> Signed-off-by: Yan-Hsuan Chuang > > [...] > >> +static struct rtw_pwr_seq_cmd trans_carddis_to_cardemu_8822b[] = { >> + {0x0086, >> + RTW_PWR_CUT_ALL_MSK, >> + RTW_PWR_INTF_SDIO_MSK, >> + RTW_PWR_ADDR_SDIO, >> + RTW_PWR_CMD_WRITE, BIT(0), 0}, > > I see lots of arrays like this which are not const. I think they should > be const. And I'm seeing even more of these while I review the driver. So basically all static variables should be const to make sure you don't accidentally between driver instances. IIRC there was something in cfg80211 API which prevent to use const (maybe the channels? can't remember now) but that's just an exception to the rule. -- Kalle Valo