From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-wireless@vger.kernel.org, pkshih@realtek.com
Subject: Re: [PATCH 0/8] rtlwifi: Remove CamelCase variables from all drivers
Date: Fri, 15 Feb 2019 12:54:04 +0200 [thread overview]
Message-ID: <87wom1xqyb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20190214223644.8035-1-Larry.Finger@lwfinger.net> (Larry Finger's message of "Thu, 14 Feb 2019 16:36:36 -0600")
Larry Finger <Larry.Finger@lwfinger.net> writes:
> This set of patches fix all instances of CamelCase for all the drivers.
> When the symbol refers to a macro, it is converted to upper case. If a
> variable or a function, then it is converted to lower case.
>
> As noted in the comments, some of the other checkpatch exceptions are
> addressed.
I wish you had separated the camel case fixes from other cleanups, and
otherwise tried to simplify the patches, now you made the patchset
painful to review as all the changes are mixed and the size of patches
is just too large. Remember that the rule of thumb is one logical change
per patch. Of course that's not a hard rule, and can be ignored with
small and trivial patches, but most of the patches here are not small.
No need to resend because of this but please take care with the size of
patches and patchsets in the future.
--
Kalle Valo
prev parent reply other threads:[~2019-02-15 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 22:36 [PATCH 0/8] rtlwifi: Remove CamelCase variables from all drivers Larry Finger
2019-02-14 22:36 ` [PATCH 1/8] rtlwifi: Remove CamelCase variables from base code Larry Finger
2019-02-19 15:04 ` Kalle Valo
2019-02-14 22:36 ` [PATCH 2/8] rtlwifi: btcoexist: Remove CamelCase variable Larry Finger
2019-02-14 22:36 ` [PATCH 3/8] rtlwifi: rtl8188ee: " Larry Finger
2019-02-14 22:36 ` [PATCH 4/8] rtlwifi: rtl8192{c,u}: Remove CamelCase variables Larry Finger
2019-02-14 22:36 ` [PATCH 5/8] rtlwifi: rtl8188de: " Larry Finger
2019-02-14 22:36 ` [PATCH 6/8] rtlwifi: rtl8192se: " Larry Finger
2019-02-14 22:36 ` [PATCH 7/8] rtlwifi: rtl8723{be,ae}: " Larry Finger
2019-02-14 22:36 ` [PATCH 8/8] rtlwifi: rtl8821ae: " Larry Finger
2019-02-15 10:54 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wom1xqyb.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox