linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: ath10k-regression due to "ath10k: fix napi_poll budget overflow" c9353bf483d3
       [not found]   ` <fa6e3ee2-91b5-a54b-afe3-87f30aac7a48@leemhuis.info>
@ 2017-10-27  9:40     ` Kalle Valo
  2017-10-27 19:01       ` Ryan Hsu
  0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2017-10-27  9:40 UTC (permalink / raw)
  To: Thorsten Leemhuis
  Cc: Ryan Hsu, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org

KyBsaW51eC13aXJlbGVzcw0KDQpUaG9yc3RlbiBMZWVtaHVpcyA8bGludXhAbGVlbWh1aXMuaW5m
bz4gd3JpdGVzOg0KDQo+IExvISBPbiAwMy4xMC4yMDE3IDAxOjQwLCBSeWFuIEhzdSB3cm90ZToN
Cj4+IE9uIDEwLzAxLzIwMTcgMDE6NTkgQU0sIFRob3JzdGVuIExlZW1odWlzIHdyb3RlOg0KPj4+
IExvISBUaGUgd2lmaSBjb25uZWN0aW9uIG9mIG15IERlbGwgWFBTMTMgKDkzNjApIHdpdGggaXRz
IFFDQTYxNzQNCj4+PiBzb21ldGltZXMgc3VkZGVubHkgc3RvcHMgd29ya2luZyBzaW5jZSBJIHN3
aXRjaGVkIHRvIDQuMTQtcmMyKy4gRXZlcnkNCj4+PiB0aW1lIGl0IGhhcHBlbnMsIHRoZXJlIGlz
IHRoaXMgZXJyb3IgbWVzc2FnZSBpbiBkbWVzZzoNCj4+Pj4gYXRoMTBrX3BjaSAwMDAwOjNhOjAw
LjA6IGZhaWxlZCB0byBleHRyYWN0IGFtc2R1OiAtMTENCj4+PiBJIGhhdmUgdG8gc3dpdGNoIHdp
Zmkgb2ZmIGFuZCBvbiB3aXRoIHRoZSBob3RrZXkgdG8gcmVjb25uZWN0LiBJIGNhbg0KPj4+IHRy
aWdnZXIgdGhlIGFib3J0cyBieSBzdGFydGluZyBhIGJpZyBkb3dubG9hZCBhbmQgd2FpdGluZyBh
IGZldyBtaW51dGVzLg0KPj4+IFNvbWV0aW1lcyB0aGUgY29ubmVjdGlvbnMgYWJvcnRzIGR1cmlu
ZyBub3JtYWwgbG9hZC4gSW5zdGFsbGluZyB0aGUNCj4+PiBsYXRlc3QgZmlybXdhcmUgZGlkbid0
IGhlbHAuIFRoZSB3aWZpIHdvcmtzIGp1c3QgZmluZSB3aXRoIDQuMTMuMy4gV2hpbGUNCj4+PiBp
bnZlc3RpZ2F0aW5nIHRoaXMgSSBub3RpY2VkIGEgZmV3IG1lc3NhZ2VzIGluIGRtZXNnIHRoYXQg
b25seSBhcHBlYXIgaW4NCj4+PiA0LjE0LXJjIChJIHVzZWQgMzVkYmJhMzFiZTUyKToNCj4+IFlv
dSBkbyBydW4gdGhlIDQuMTMuMyB2LnMgNC4xNC1yYyB3aXRoIHRoZSBzYW1lIFFDQTYxNzQgZmly
bXdyYWUsIHJpZ2h0Pw0KPj4gSnVzdCB3YW50IHRvIHVuZGVyc3RhbmQgdGhlIHRlc3Qgc2V0dXAg
aGVyZSBzbyB0aGF0IEkgY291bGQgZ2l2ZSBpdA0KPj4gYSB0cnkgbXlzZWxmLCBhbmQgaW4gMTFh
YyBvciAxMW4gbW9kZSB5b3UncmUgdGVzdGluZz8NCj4NCj4gWXVwLCBzYW1lIGZpcm13YXJlIChy
ZXByb2R1Y2VkIGl0IHdpdGgNCj4gZmlybXdhcmUtNi5iaW5fV0xBTi5STS40LjQuMS0wMDA1OC1R
Q0FSTVNXUC0xIGJlZm9yZSBiaXNlY3RpbmcpLiBBbmQgdGhlDQo+IHByb2JsZW0gc2hvd2VkIHVw
IHdpdGggMmcgYW5kIDVnIG5ldHdvcmtzLiBCdXQgd2hpbGUgaW52ZXN0aWdhdGluZyBpdCBJDQo+
IG5vdGljZWQgdGhlIHByb2JsZW0gZG9lcyBub3Qgc2hvdyB1cCB3aXRoIGFsbCB3aWZpIHJvdXRl
cnMuIEl0IGhhcHBlbnMNCj4gd2l0aCBteSBGcml0eiFCb3ggNjQ5MCBDYWJsZSBhbmQgYW5vdGhl
ciBGcml0eiFCb3ggSSB0cmllZCwgYnV0IG5vdCB3aXRoDQo+IHRoZSB3aWZpIG5ldHdvcmsgYXQg
d29yayAobm8gaWRlYSB3aGF0IGtpbmQgb2Ygcm91dGVycyBhcmUgaW5zdGFsbGVkDQo+IHRoZXJl
OyBJIGNhbiB0cnkgdG8gZmluZCBvdXQgaWYgaXQgbWF0dGVycykuDQo+DQo+Pj4+IDNhOjAwLjAg
TmV0d29yayBjb250cm9sbGVyIFswMjgwXTogUXVhbGNvbW0gQXRoZXJvcyBRQ0E2MTc0DQo+Pj4+
IDgwMi4xMWFjIFdpcmVsZXNzIE5ldHdvcmsgQWRhcHRlciBbMTY4YzowMDNlXSAocmV2IDMyKQ0K
Pj4gW+KApl0gV291bGQgeW91IG1pbmQgZG8gYSBiaXNlY3QgdG8gbG9jYXRlIHRoZSBmYWlsdXJl
LCBwbGVhc2U/DQo+DQo+IERpZCB0aGF0IHllc3RlcmRheSBhbmQgaXQgdHVybmVkIG91dCBpdCdz
IGR1ZSB0byBjb21taXQgYzkzNTNiZjQ4M2QzDQo+IChhdGgxMGs6IGZpeCBuYXBpX3BvbGwgYnVk
Z2V0IG92ZXJmbG93KS4gUmV2ZXJ0aW5nIGl0IG9uIHRvcCBvZiBsaW51eA0KPiBtYXN0ZXIgZnJv
bSB5ZXN0ZXJkYXkgbWFkZSB0aGUgd2lmaSBjb25uZWN0aW9uIHN0YWJsZSBhZ2FpbiBmb3IgbWUu
DQoNClNvcnJ5LCBJIGhhdmUgbm90IGJlZW4gYWJsZSB0byBmb2xsb3cgdGhpcyBkaXNjdXNzaW9u
IHZlcnkgY2xvc2VseSBidXQNCndhcyB0aGUgY29uY2x1c2lvbj8gU2hvdWxkIHdlIHNob3VsZCBy
ZXZlcnQgYzkzNTNiZjQ4M2QzIGZvciA0LjE0IG9yDQp3aGF0PyBJIHNob3VsZCBzdGlsbCBoYXZl
IHRpbWUgdG8gZG8gdGhhdCwgYnV0IG5vdCBtdWNoLg0KDQotLSANCkthbGxlIFZhbG8=

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: ath10k-regression due to "ath10k: fix napi_poll budget overflow" c9353bf483d3
  2017-10-27  9:40     ` ath10k-regression due to "ath10k: fix napi_poll budget overflow" c9353bf483d3 Kalle Valo
@ 2017-10-27 19:01       ` Ryan Hsu
  2017-10-29  7:44         ` Kalle Valo
  0 siblings, 1 reply; 8+ messages in thread
From: Ryan Hsu @ 2017-10-27 19:01 UTC (permalink / raw)
  To: Kalle Valo, Thorsten Leemhuis
  Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org

T24gMTAvMjcvMjAxNyAwMjo0MCBBTSwgS2FsbGUgVmFsbyB3cm90ZToNCg0KPiArIGxpbnV4LXdp
cmVsZXNzDQo+DQo+IFNvcnJ5LCBJIGhhdmUgbm90IGJlZW4gYWJsZSB0byBmb2xsb3cgdGhpcyBk
aXNjdXNzaW9uIHZlcnkgY2xvc2VseSBidXQNCj4gd2FzIHRoZSBjb25jbHVzaW9uPyBTaG91bGQg
d2Ugc2hvdWxkIHJldmVydCBjOTM1M2JmNDgzZDMgZm9yIDQuMTQgb3INCj4gd2hhdD8gSSBzaG91
bGQgc3RpbGwgaGF2ZSB0aW1lIHRvIGRvIHRoYXQsIGJ1dCBub3QgbXVjaC4NCg0KS2FsbGUsIEkg
ZG9uJ3QgdGhpbmsgSSBoYXZlIGVub3VnaCB0aW1lIHRvIGxvb2sgaW50byB0aGUgaXNzdWUsIHNp
bmNlIG9yaWdpbmFsIGNoYW5nZSBpcyB0byBhdm9pZCB0aGUgd2FybmluZywgYnV0IG5vdyBpcyBo
YXZpbmcgcmVncmVzc2lvbi4NCkxldCdzIHRyeSB0byByZXZlcnQgYzkzNTNiZjQ4M2QzIGZvciA0
LjE0LCBhbmQgSSdsbCBsb29rIGludG8gdGhpcyBsYXRlci4NCg0KLS0gDQpSeWFuIEhzdQ0K

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: ath10k-regression in 4.14: Connections aborts with "failed to extract amsdu: -11"
       [not found] ` <46f918c5-b07d-e397-2f3d-8136c7c1a8f3@qti.qualcomm.com>
       [not found]   ` <fa6e3ee2-91b5-a54b-afe3-87f30aac7a48@leemhuis.info>
@ 2017-10-29  7:06   ` Kalle Valo
       [not found]   ` <74a979dc-f06d-be9d-7c3f-359cd481d16c@leemhuis.info>
  2 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2017-10-29  7:06 UTC (permalink / raw)
  To: Ryan Hsu
  Cc: Thorsten Leemhuis, ath10k@lists.infradead.org,
	linux-wireless@vger.kernel.org

+ linux-wireless

Ryan Hsu <ryanhsu@qti.qualcomm.com> writes:

>>> ath10k_pci 0000:3a:00.0: Direct firmware load for
>>> ath10k/pre-cal-pci-0000:3a:00.0.bin failed with error -2
>>> ath10k_pci 0000:3a:00.0: Direct firmware load for
>>> ath10k/cal-pci-0000:3a:00.0.bin failed with error -2
>> Do they have anything to do with this? Hardware is
>
> This error message is confusing since QCA6174 is not supporting
> pre-calibration feature, this reminds me that we need to clean this
> up.

These warnings come up again because of this commit:

c0cc00f250e1 ath10k: activate user space firmware loading again

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=3Da=
th-next&id=3Dc0cc00f250e19c717fc9cdbdb7f55aaa569c7498

We really need a function like request_firmware_nowarn() which would not
print a warning everytime a file is not found. It just confuses the
users and make them falsely believe that's the reason of their problems.

--=20
Kalle Valo=

^ permalink raw reply	[flat|nested] 8+ messages in thread

* ath10k: Wifi slow on the XPS13 (9360) (QCA6174)
       [not found]   ` <74a979dc-f06d-be9d-7c3f-359cd481d16c@leemhuis.info>
@ 2017-10-29  7:27     ` Kalle Valo
  2017-10-31 15:47       ` Thorsten Leemhuis
  0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2017-10-29  7:27 UTC (permalink / raw)
  To: Thorsten Leemhuis
  Cc: Ryan Hsu, ath10k@lists.infradead.org, Paul Menzel,
	linux-wireless@vger.kernel.org

KyBsaW51eC13aXJlbGVzcyBhbmQgY2xlYW5pbmcgdGhlIHN1YmplY3QNCg0KSGkgVGhvcnN0ZW4s
DQoNCnNvcnJ5IGZvciB0aGUgbGF0ZSByZXBseSwgSSdtIGhhdmluZyBwcm9ibGVtcyBrZWVwaW5n
IHVwIHdpdGggYWxsIHRoZQ0KZW1haWwuIEkganVzdCBkbyBhIHF1aWNrIHJlcGx5IG5vdyB0byBw
b2ludCBvdXQgdGhhdCB5b3UgYXJlIHRhbGtpbmcNCmFib3V0IHR3byBkaWZmZXJlbnQgcHJvYmxl
bXMuIFRvIGtlZXAgdGhlIGRpc2N1c3Npb24gc2ltcGxlIEkgcmVjb21tZW5kDQprZWVwaW5nIHRo
ZSB0d28gaXNzdWVzIGNvbXBsZXRlIHNlcGFyYXRlLg0KDQpUaG9yc3RlbiBMZWVtaHVpcyA8bGlu
dXhAbGVlbWh1aXMuaW5mbz4gd3JpdGVzOg0KDQo+IExvISBTcGxpdHRpbmcgdGhpcyB0aHJlYWQg
dG8gZm9jdXMgb24gYSBpc3N1ZSB0aGF0IGhhcyBub3RoaW5nIHRvIGRvDQo+IHdpdGggdGhlIHJl
Z3Jlc3Npb24gaW4gNC4xNCBJIHJlcG9ydGVkOg0KPg0KPiBPbiAwMy4xMC4yMDE3IDAxOjQwLCBS
eWFuIEhzdSB3cm90ZToNCj4+IE9uIDEwLzAxLzIwMTcgMDE6NTkgQU0sIFRob3JzdGVuIExlZW1o
dWlzIHdyb3RlOg0KPj4+PiBhdGgxMGtfcGNpIDAwMDA6M2E6MDAuMDogRGlyZWN0IGZpcm13YXJl
IGxvYWQgZm9yDQo+Pj4+IGF0aDEway9wcmUtY2FsLXBjaS0wMDAwOjNhOjAwLjAuYmluIGZhaWxl
ZCB3aXRoIGVycm9yIC0yDQo+Pj4+IGF0aDEwa19wY2kgMDAwMDozYTowMC4wOiBEaXJlY3QgZmly
bXdhcmUgbG9hZCBmb3INCj4+Pj4gYXRoMTBrL2NhbC1wY2ktMDAwMDozYTowMC4wLmJpbiBmYWls
ZWQgd2l0aCBlcnJvciAtMg0KPj4+IERvIHRoZXkgaGF2ZSBhbnl0aGluZyB0byBkbyB3aXRoIHRo
aXM/IEhhcmR3YXJlIGlzDQo+PiBUaGlzIGVycm9yIG1lc3NhZ2UgaXMgY29uZnVzaW5nIHNpbmNl
IFFDQTYxNzQgaXMgbm90IHN1cHBvcnRpbmcNCj4+IHByZS1jYWxpYnJhdGlvbiBmZWF0dXJlLCB0
aGlzIHJlbWluZHMgbWUgdGhhdCB3ZSBuZWVkIHRvIGNsZWFuIHRoaXMgdXAuDQo+DQo+IEkgZ3Vl
c3MgdGhhdCB3b3VsZCBiZSBnb29kIHRvIGF2b2lkIGNvbmZ1c2lvbi4gQnV0IHdoaWxlIGF0IGl0
OiBJZiB5b3UNCj4gaGF2ZSBhIG1pbnV0ZSwgY291bGQgeW91IHBsZWFzZSBleHBsYWluIHRvIG1l
IGhvdyB0byBwcm9wZXJseSBzZXQgdXAgdGhlDQo+IHdpZmkgZmlybXdhcmUgZmlsZXMgZm9yIG15
IERlbGwgWFBTMTMgKDkzNjApPyBUaGUgcmVhc29ucyB3aHkgSSdtDQo+IGFza2luZzogU2VuZGlu
ZyBkYXRhIHZpYSB3aWZpIGlzIHJlYWxseSBzbG93IG9uIG15IGxhcHRvcCAoc2NwIGNvcGllcw0K
PiBvbmx5IGdldCAyIHRvIDUgTUJ5dGUvcyBvbiBuZXR3b3JrcyB0aGF0IGFyZSBrbm93biB0byBi
ZSBhIGxvdCBmYXN0ZXIpLg0KPiBJIHdvbmRlciBpZiB0aGUgZmlybXdhcmUgZmlsZXMgb3IgdGhl
IGNhbGlicmF0aW9uIGRhdGEgaXMgcGFydCBvZiB0aGUNCj4gcmVhc29uIHdpZmkgVHggaXMgc2xv
dy4gVGhlIG1hY2hpbmUgaXMgbm9ybWFsbHkgc2hpcHBlZCB3aXRoIGEgc2xpZ2h0bHkNCj4gZW5o
YW5jZWQgVWJ1bnR1IDE2LjA0LiBUaGF0IGFtb25nIG90aGVycyBjb250YWlucyBhIHBhY2thZ2Ug
d2l0aCB0aGUNCj4gbWFjaGluZSBzcGVjaWZpYyBmaWxlcyBib2FyZC5iaW4gYW5kIGJvYXJkLTIu
YmluIHRoYXQgcmVwbGFjZSB0aGUgZmlsZXMNCj4gbm9ybWFsbHkgaW5zdGFsbGVkIGluIC9saWIv
ZmlybXdhcmUvYXRoMTBrL1FDQTYxNzQvaHczLjAvIEFyZSB0aG9zZQ0KPiBtYWNoaW5lIHNwZWNp
ZmljIGZpbGVzIGNydWNpYWwgdG8gaGF2ZSBvciBhcmUgdGhlIG9uZSBmcm9tIHRoZQ0KPiBsaW51
eC1maXJtd2FyZSByZXBvIGdvb2QgZW5vZ3VoPyBJJ20gdXNpbmcgRmVkb3JhIGFuZCBjb3VsZCBj
b3B5IHRoZQ0KPiBvbmVzIGZyb20gVWJ1bnR1IG92ZXIsIGJ1dCBvYnZpb3VzbHkgdGhleSB3aWxs
IGdldCBvdmVyd3JpdHRlbiBldmVyeQ0KPiB0aW1lIEZlZG9yYSBzaGlwcyBhIG5ldyBsaW51eC1m
aXJtd2FyZSBwYWNrYWdlIOKAkyBJT1c6IGV2ZXJ5IGZldyB3ZWVrcyA6LS8NCg0KWWVzLCB0aGUg
Ym9hcmQgZmlsZSBjYW4gYWZmZWN0IHRocm91Z2h0cHV0LCBfYm90aF8gVENQIGFuZCBVRFAuIEkg
ZG9uJ3QNCmtub3cgd2hhdCBib2FyZCBmaWxlcyBVYnVudHUgaXMgc2hpcHBpbmcgYnV0IHdlIHNo
b3VsZCB0cnkgdG8gZ2V0IHRob3NlDQppbnRvIHVwc3RyZWFtLg0KDQo+IFNpZGUgbm90ZTogWW91
IGZpbmQgYSBsb3Qgb2YgcmVwb3J0cyBhYm91dCBzbG93IHdpZmkgaXMgeW91IHNlYXJjaCB0aGUN
Cj4gbmV0IHdpdGggdGVybXMgbGlrZSAiOTM2MCB3aWZpIHNsb3cgbGludXgiLiBVYnVudHUgZml4
ZWQgdGhhdCBhIGZldw0KPiBtb250aHMgYWdvIHdpdGggdGhpcyBwYXRjaDoNCj4gaHR0cDovL2tl
cm5lbC51YnVudHUuY29tL2dpdC91YnVudHUvdWJ1bnR1LXhlbmlhbC5naXQvY29tbWl0Lz9pZD05
NjkwZjE5ZjA3ZmVlMmFjYjJiMDRlYTVlYWE1ZGIxODRlZTE3NWQ1DQo+DQo+IFNvbWUgYnVncyBh
Ym91dCB0aGlzOg0KPiBodHRwczovL2J1Z3MubGF1bmNocGFkLm5ldC91YnVudHUvK3NvdXJjZS9s
aW51eC8rYnVnLzE2OTI4MzYNCj4gaHR0cHM6Ly9idWdzLmxhdW5jaHBhZC5uZXQvdWJ1bnR1Lytz
b3VyY2UvbGludXgvK2J1Zy8xNjcwMDQxDQoNCkJ1dCB0aGlzIGFnYWluIGFib3V0IGludGVycmFj
dGlvbiBiZXR3ZWVuIGF0aDEwayBhbmQgVENQIHN0YWNrLiBBbmQgaXQNCl9vbmx5XyBhZmZlY3Rz
IFRDUCwgVURQIHNob3VsZCBiZSB1bmFmZmVjdGVkLiBTbyB3aGVuZXZlciB0ZXN0aW5nDQp0aHJv
dWdocHV0IHBsZWFzZSBhbHdheXMgbWVhc3VyZSBib3RoIFRDUCBhbmQgVURQIGJlY2F1c2UgdGhl
biBpdCdzDQplYXNpZXIgdG8gcGlucG9pbnQgdGhlIHJlYXNvbi4NCg0KPiBCdXQgZnJvbSB3aGF0
IEkgZ2F0aGVyZWQgYnkgc2VhcmNoaW5nIHRoZSBuZXQgYW5kIGFza2luZyBvbiAjYXRoMTBrIEkN
Cj4gZ290IHRoZSBpbXByZXNzaW9uIHRoYXQgcGF0Y2ggaXMgYSBtYXNzaXZlIHVnbHkgaGFjayBh
bmQgbm8gd2F5DQo+IGFjY2VwdGFibGUgdXBzdHJlYW0uICBJcyB0aGF0IGNvcnJlY3Q/DQoNClll
cywgaXQncyBhIGhvcnJpYmxlIGhhY2sgYW5kIEkgY2Fubm90IGFwcGx5IHRoYXQuIEFuZCBsaWtl
IHlvdSBzYWlkDQojMTY5MjgzNiwgYWxzbyBFcmljIER1bWF6ZXQgKG9uZSBvZiBUQ1AgbWFpbnRh
aW5lcnMpIGFncmVlcyB3aXRoIHRoYXQuDQoNCj4gSWYgeWVzOiBpcyB0aGVyZSBtYXliZSBhIHBy
b3BlciBmaXggb3V0IHRoZXJlIHNvbWV3aGVyZT8NCg0KVW5mb3J0dW5hdGVseSB0aGVyZSBzdGls
bCBpcyBubyBnb29kIHNvbHV0aW9uLiBJbiBhIHdlZWsgdGhlcmUncyBOZXRkZXYNCjIuMiBhbmQg
d2UgaGF2ZSBMaW51eCBXaXJlbGVzcyBzdW1taXQgdGhlcmUuIFdlIHNob3VsZCBicmluZyB1cCB0
aGlzDQp0b3BpYyB0aGVyZS4NCg0KLS0gDQpLYWxsZSBWYWxv

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: ath10k-regression due to "ath10k: fix napi_poll budget overflow" c9353bf483d3
  2017-10-27 19:01       ` Ryan Hsu
@ 2017-10-29  7:44         ` Kalle Valo
  2017-10-29 10:21           ` Thorsten Leemhuis
  0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2017-10-29  7:44 UTC (permalink / raw)
  To: Ryan Hsu
  Cc: Thorsten Leemhuis, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org

Ryan Hsu <ryanhsu@qti.qualcomm.com> writes:

> On 10/27/2017 02:40 AM, Kalle Valo wrote:
>
>> + linux-wireless
>>
>> Sorry, I have not been able to follow this discussion very closely but
>> was the conclusion? Should we should revert c9353bf483d3 for 4.14 or
>> what? I should still have time to do that, but not much.
>
> Kalle, I don't think I have enough time to look into the issue, since
> original change is to avoid the warning, but now is having regression.
> Let's try to revert c9353bf483d3 for 4.14, and I'll look into this later.

Great, thanks Ryan.

I now submitted the revert and I'll try to get it to 4.14:

https://patchwork.kernel.org/patch/10031233/

--=20
Kalle Valo=

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: ath10k-regression due to "ath10k: fix napi_poll budget overflow" c9353bf483d3
  2017-10-29  7:44         ` Kalle Valo
@ 2017-10-29 10:21           ` Thorsten Leemhuis
  0 siblings, 0 replies; 8+ messages in thread
From: Thorsten Leemhuis @ 2017-10-29 10:21 UTC (permalink / raw)
  To: Kalle Valo, Ryan Hsu
  Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org

Lo! On 29.10.2017 08:44, Kalle Valo wrote:
> Ryan Hsu <ryanhsu@qti.qualcomm.com> writes:
>> On 10/27/2017 02:40 AM, Kalle Valo wrote:
>>
>>> + linux-wireless
>>> Sorry, I have not been able to follow this discussion very closely but
>>> was the conclusion? Should we should revert c9353bf483d3 for 4.14 or
>>> what? I should still have time to do that, but not much.
>> Kalle, I don't think I have enough time to look into the issue, since
>> original change is to avoid the warning, but now is having regression.
>> Let's try to revert c9353bf483d3 for 4.14, and I'll look into this later.
> 
> Great, thanks Ryan.
> I now submitted the revert and I'll try to get it to 4.14:
> https://patchwork.kernel.org/patch/10031233/

Sorry, I'm a bit behind with my mail after lot's of work@work and some
travelling right after that.

Ryan, Kalle: Thx for taking care of this. If you sooner or later want me
to test patches that try to solve the warning without causing this
regression simply drop me a line. Ciao, Thorsten

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: ath10k: Wifi slow on the XPS13 (9360) (QCA6174)
  2017-10-29  7:27     ` ath10k: Wifi slow on the XPS13 (9360) (QCA6174) Kalle Valo
@ 2017-10-31 15:47       ` Thorsten Leemhuis
  2017-11-01  7:25         ` Kalle Valo
  0 siblings, 1 reply; 8+ messages in thread
From: Thorsten Leemhuis @ 2017-10-31 15:47 UTC (permalink / raw)
  To: Kalle Valo
  Cc: Ryan Hsu, ath10k@lists.infradead.org, Paul Menzel,
	linux-wireless@vger.kernel.org

Lo! On 29.10.2017 08:27, Kalle Valo wrote:
> [..]
> sorry for the late reply, I'm having problems keeping up with all the
> email. 

No worries, this problem is nothing new, I just thought it might be good
to finally bring this to ath10k, as I got the impressions it had not
gotten proper attention there yet.

> Thorsten Leemhuis <linux@leemhuis.info> writes:
>> On 03.10.2017 01:40, Ryan Hsu wrote:
>>> On 10/01/2017 01:59 AM, Thorsten Leemhuis wrote:
>>>>> ath10k_pci 0000:3a:00.0: Direct firmware load for
>>>>> ath10k/pre-cal-pci-0000:3a:00.0.bin failed with error -2
>>>>> ath10k_pci 0000:3a:00.0: Direct firmware load for
>>>>> ath10k/cal-pci-0000:3a:00.0.bin failed with error -2
>>>> Do they have anything to do with this? Hardware is
>>> This error message is confusing since QCA6174 is not supporting
>>> pre-calibration feature, this reminds me that we need to clean this up.
>> I guess that would be good to avoid confusion. But while at it: If you
>> have a minute, could you please explain to me how to properly set up the
>> wifi firmware files for my Dell XPS13 (9360)? The reasons why I'm
>> asking: Sending data via wifi is really slow on my laptop (scp copies
>> only get 2 to 5 MByte/s on networks that are known to be a lot faster).
>> I wonder if the firmware files or the calibration data is part of the
>> reason wifi Tx is slow. The machine is normally shipped with a slightly
>> enhanced Ubuntu 16.04. That among others contains a package with the
>> machine specific files board.bin and board-2.bin that replace the files
>> normally installed in /lib/firmware/ath10k/QCA6174/hw3.0/ Are those
>> machine specific files crucial to have or are the one from the
>> linux-firmware repo good enoguh? I'm using Fedora and could copy the
>> ones from Ubuntu over, but obviously they will get overwritten every
>> time Fedora ships a new linux-firmware package – IOW: every few weeks :-/
> Yes, the board file can affect throughtput, _both_ TCP and UDP. I don't
> know what board files Ubuntu is shipping but we should try to get those
> into upstream.

Out of curiosity (don't spend time answering this is you are busy): Is
there even a mechanism for this? Kind of "take
firmwaredir/board-Dell_Inc.-XPS_13_9360.bin if it exists and
firmwaredir/board.bin otherwise? Or can one file serve all machines?

>> Side note: You find a lot of reports about slow wifi is you search the
>> net with terms like "9360 wifi slow linux". Ubuntu fixed that a few
>> months ago with this patch:
>> http://kernel.ubuntu.com/git/ubuntu/ubuntu-xenial.git/commit/?id=9690f19f07fee2acb2b04ea5eaa5db184ee175d5
>> Some bugs about this:
>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1692836
>> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1670041
> But this again about interraction between ath10k and TCP stack. And it
> _only_ affects TCP, UDP should be unaffected.

Ahh, sorry, missed that. Seems I didn't properly read the second
launchpad link above. Sorry.

> So whenever testing
> throughput please always measure both TCP and UDP because then it's
> easier to pinpoint the reason.

Is there any data I could provide that might help getting this soled
once and for all?

>> But from what I gathered by searching the net and asking on #ath10k I
>> got the impression that patch is a massive ugly hack and no way
>> acceptable upstream.  Is that correct?
> Yes, it's a horrible hack and I cannot apply that. And like you said
> #1692836, also Eric Dumazet (one of TCP maintainers) agrees with that
Ahh, had missed that, sorry.

>> If yes: is there maybe a proper fix out there somewhere?
> Unfortunately there still is no good solution. In a week there's Netdev
> 2.2 and we have Linux Wireless summit there. We should bring up this
> topic there.

Thx for picking this up, much appreciated! Ciao, Thorsten

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: ath10k: Wifi slow on the XPS13 (9360) (QCA6174)
  2017-10-31 15:47       ` Thorsten Leemhuis
@ 2017-11-01  7:25         ` Kalle Valo
  0 siblings, 0 replies; 8+ messages in thread
From: Kalle Valo @ 2017-11-01  7:25 UTC (permalink / raw)
  To: Thorsten Leemhuis
  Cc: Ryan Hsu, ath10k@lists.infradead.org, Paul Menzel,
	linux-wireless@vger.kernel.org

VGhvcnN0ZW4gTGVlbWh1aXMgPGxpbnV4QGxlZW1odWlzLmluZm8+IHdyaXRlczoNCg0KPiBMbyEg
T24gMjkuMTAuMjAxNyAwODoyNywgS2FsbGUgVmFsbyB3cm90ZToNCj4+IFRob3JzdGVuIExlZW1o
dWlzIDxsaW51eEBsZWVtaHVpcy5pbmZvPiB3cml0ZXM6DQo+Pj4gT24gMDMuMTAuMjAxNyAwMTo0
MCwgUnlhbiBIc3Ugd3JvdGU6DQo+Pj4+IE9uIDEwLzAxLzIwMTcgMDE6NTkgQU0sIFRob3JzdGVu
IExlZW1odWlzIHdyb3RlOg0KPj4+Pj4+IGF0aDEwa19wY2kgMDAwMDozYTowMC4wOiBEaXJlY3Qg
ZmlybXdhcmUgbG9hZCBmb3INCj4+Pj4+PiBhdGgxMGsvcHJlLWNhbC1wY2ktMDAwMDozYTowMC4w
LmJpbiBmYWlsZWQgd2l0aCBlcnJvciAtMg0KPj4+Pj4+IGF0aDEwa19wY2kgMDAwMDozYTowMC4w
OiBEaXJlY3QgZmlybXdhcmUgbG9hZCBmb3INCj4+Pj4+PiBhdGgxMGsvY2FsLXBjaS0wMDAwOjNh
OjAwLjAuYmluIGZhaWxlZCB3aXRoIGVycm9yIC0yDQo+Pj4+PiBEbyB0aGV5IGhhdmUgYW55dGhp
bmcgdG8gZG8gd2l0aCB0aGlzPyBIYXJkd2FyZSBpcw0KPj4+PiBUaGlzIGVycm9yIG1lc3NhZ2Ug
aXMgY29uZnVzaW5nIHNpbmNlIFFDQTYxNzQgaXMgbm90IHN1cHBvcnRpbmcNCj4+Pj4gcHJlLWNh
bGlicmF0aW9uIGZlYXR1cmUsIHRoaXMgcmVtaW5kcyBtZSB0aGF0IHdlIG5lZWQgdG8gY2xlYW4g
dGhpcyB1cC4NCj4+PiBJIGd1ZXNzIHRoYXQgd291bGQgYmUgZ29vZCB0byBhdm9pZCBjb25mdXNp
b24uIEJ1dCB3aGlsZSBhdCBpdDogSWYgeW91DQo+Pj4gaGF2ZSBhIG1pbnV0ZSwgY291bGQgeW91
IHBsZWFzZSBleHBsYWluIHRvIG1lIGhvdyB0byBwcm9wZXJseSBzZXQgdXAgdGhlDQo+Pj4gd2lm
aSBmaXJtd2FyZSBmaWxlcyBmb3IgbXkgRGVsbCBYUFMxMyAoOTM2MCk/IFRoZSByZWFzb25zIHdo
eSBJJ20NCj4+PiBhc2tpbmc6IFNlbmRpbmcgZGF0YSB2aWEgd2lmaSBpcyByZWFsbHkgc2xvdyBv
biBteSBsYXB0b3AgKHNjcCBjb3BpZXMNCj4+PiBvbmx5IGdldCAyIHRvIDUgTUJ5dGUvcyBvbiBu
ZXR3b3JrcyB0aGF0IGFyZSBrbm93biB0byBiZSBhIGxvdCBmYXN0ZXIpLg0KPj4+IEkgd29uZGVy
IGlmIHRoZSBmaXJtd2FyZSBmaWxlcyBvciB0aGUgY2FsaWJyYXRpb24gZGF0YSBpcyBwYXJ0IG9m
IHRoZQ0KPj4+IHJlYXNvbiB3aWZpIFR4IGlzIHNsb3cuIFRoZSBtYWNoaW5lIGlzIG5vcm1hbGx5
IHNoaXBwZWQgd2l0aCBhIHNsaWdodGx5DQo+Pj4gZW5oYW5jZWQgVWJ1bnR1IDE2LjA0LiBUaGF0
IGFtb25nIG90aGVycyBjb250YWlucyBhIHBhY2thZ2Ugd2l0aCB0aGUNCj4+PiBtYWNoaW5lIHNw
ZWNpZmljIGZpbGVzIGJvYXJkLmJpbiBhbmQgYm9hcmQtMi5iaW4gdGhhdCByZXBsYWNlIHRoZSBm
aWxlcw0KPj4+IG5vcm1hbGx5IGluc3RhbGxlZCBpbiAvbGliL2Zpcm13YXJlL2F0aDEway9RQ0E2
MTc0L2h3My4wLyBBcmUgdGhvc2UNCj4+PiBtYWNoaW5lIHNwZWNpZmljIGZpbGVzIGNydWNpYWwg
dG8gaGF2ZSBvciBhcmUgdGhlIG9uZSBmcm9tIHRoZQ0KPj4+IGxpbnV4LWZpcm13YXJlIHJlcG8g
Z29vZCBlbm9ndWg/IEknbSB1c2luZyBGZWRvcmEgYW5kIGNvdWxkIGNvcHkgdGhlDQo+Pj4gb25l
cyBmcm9tIFVidW50dSBvdmVyLCBidXQgb2J2aW91c2x5IHRoZXkgd2lsbCBnZXQgb3ZlcndyaXR0
ZW4gZXZlcnkNCj4+PiB0aW1lIEZlZG9yYSBzaGlwcyBhIG5ldyBsaW51eC1maXJtd2FyZSBwYWNr
YWdlIOKAkyBJT1c6IGV2ZXJ5IGZldyB3ZWVrcyA6LS8NCj4+IFllcywgdGhlIGJvYXJkIGZpbGUg
Y2FuIGFmZmVjdCB0aHJvdWdodHB1dCwgX2JvdGhfIFRDUCBhbmQgVURQLiBJIGRvbid0DQo+PiBr
bm93IHdoYXQgYm9hcmQgZmlsZXMgVWJ1bnR1IGlzIHNoaXBwaW5nIGJ1dCB3ZSBzaG91bGQgdHJ5
IHRvIGdldCB0aG9zZQ0KPj4gaW50byB1cHN0cmVhbS4NCj4NCj4gT3V0IG9mIGN1cmlvc2l0eSAo
ZG9uJ3Qgc3BlbmQgdGltZSBhbnN3ZXJpbmcgdGhpcyBpcyB5b3UgYXJlIGJ1c3kpOiBJcw0KPiB0
aGVyZSBldmVuIGEgbWVjaGFuaXNtIGZvciB0aGlzPyBLaW5kIG9mICJ0YWtlDQo+IGZpcm13YXJl
ZGlyL2JvYXJkLURlbGxfSW5jLi1YUFNfMTNfOTM2MC5iaW4gaWYgaXQgZXhpc3RzIGFuZA0KPiBm
aXJtd2FyZWRpci9ib2FyZC5iaW4gb3RoZXJ3aXNlPyBPciBjYW4gb25lIGZpbGUgc2VydmUgYWxs
IG1hY2hpbmVzPw0KDQpKdXN0IHRvIGEgcXVpY2sgc2hvcnQgYW5zd2VyOg0KDQpib2FyZC5iaW4g
Y29udGFpbnMganVzdCBvbmUgYm9hcmQgZmlsZSBidXQgYm9hcmQtMi5iaW4gaXMgaW4gcHJhY3Rp
c2UgYQ0KY29udGFpbmVyIGZvcm1hdCB3aGljaCBoYXMgbXVsdGlwbGUgYm9hcmQgZmlsZXMgKG9y
ICJpbWFnZXMiKS4gRWFjaA0KaW1hZ2UgaGFzIGEgbmFtZSBhc3NvY2lhdGVkIHRvIGl0IHdoaWNo
IGF0aDEwayB1c2VzIHRvIGZpbmQgdGhlIGNvcnJlY3QNCmltYWdlLiBFeGFtcGxlOg0KDQpidXM9
cGNpLHZlbmRvcj0xNjhjLGRldmljZT0wMDNlLHN1YnN5c3RlbS12ZW5kb3I9MTQ0ZCxzdWJzeXN0
ZW0tZGV2aWNlPWMxNGYsdmFyaWFudD1LDQoNClNvIHllcywgd2UgaGF2ZSBpbmZyYXN0cnVjdHVy
ZSByZWFkeSB0byBwcm92aWRlIG11bHRpcGxlIGJvYXJkIGZpbGVzLg0KQnV0IHVzdWFsbHkgdGhl
IGNoYWxsZW5nZSBpcyBob3cgdG8gbWFrZSBhdGgxMGsgY29ycmVjdGx5IGRldGVjdCB3aGF0DQpi
b2FyZCBmaWxlIGEgcGFydGljdWxhciBzeXN0ZW0gbmVlZHMuDQoNCj4+PiBTaWRlIG5vdGU6IFlv
dSBmaW5kIGEgbG90IG9mIHJlcG9ydHMgYWJvdXQgc2xvdyB3aWZpIGlzIHlvdSBzZWFyY2ggdGhl
DQo+Pj4gbmV0IHdpdGggdGVybXMgbGlrZSAiOTM2MCB3aWZpIHNsb3cgbGludXgiLiBVYnVudHUg
Zml4ZWQgdGhhdCBhIGZldw0KPj4+IG1vbnRocyBhZ28gd2l0aCB0aGlzIHBhdGNoOg0KPj4+IGh0
dHA6Ly9rZXJuZWwudWJ1bnR1LmNvbS9naXQvdWJ1bnR1L3VidW50dS14ZW5pYWwuZ2l0L2NvbW1p
dC8/aWQ9OTY5MGYxOWYwN2ZlZTJhY2IyYjA0ZWE1ZWFhNWRiMTg0ZWUxNzVkNQ0KPj4+IFNvbWUg
YnVncyBhYm91dCB0aGlzOg0KPj4+IGh0dHBzOi8vYnVncy5sYXVuY2hwYWQubmV0L3VidW50dS8r
c291cmNlL2xpbnV4LytidWcvMTY5MjgzNg0KPj4+IGh0dHBzOi8vYnVncy5sYXVuY2hwYWQubmV0
L3VidW50dS8rc291cmNlL2xpbnV4LytidWcvMTY3MDA0MQ0KPj4gQnV0IHRoaXMgYWdhaW4gYWJv
dXQgaW50ZXJyYWN0aW9uIGJldHdlZW4gYXRoMTBrIGFuZCBUQ1Agc3RhY2suIEFuZCBpdA0KPj4g
X29ubHlfIGFmZmVjdHMgVENQLCBVRFAgc2hvdWxkIGJlIHVuYWZmZWN0ZWQuDQo+DQo+IEFoaCwg
c29ycnksIG1pc3NlZCB0aGF0LiBTZWVtcyBJIGRpZG4ndCBwcm9wZXJseSByZWFkIHRoZSBzZWNv
bmQNCj4gbGF1bmNocGFkIGxpbmsgYWJvdmUuIFNvcnJ5Lg0KPg0KPj4gU28gd2hlbmV2ZXIgdGVz
dGluZw0KPj4gdGhyb3VnaHB1dCBwbGVhc2UgYWx3YXlzIG1lYXN1cmUgYm90aCBUQ1AgYW5kIFVE
UCBiZWNhdXNlIHRoZW4gaXQncw0KPj4gZWFzaWVyIHRvIHBpbnBvaW50IHRoZSByZWFzb24uDQo+
DQo+IElzIHRoZXJlIGFueSBkYXRhIEkgY291bGQgcHJvdmlkZSB0aGF0IG1pZ2h0IGhlbHAgZ2V0
dGluZyB0aGlzIHNvbGVkDQo+IG9uY2UgYW5kIGZvciBhbGw/DQoNCldpdGggInRoaXMiIHlvdSBt
ZWFuIFRDUCB0cmFuc21pdCB0aHJvdWdocHV0IHByb2JsZW0gd2l0aCBhdGgxMGs/IEkNCmRvbid0
IHRoaW5rIHRoZXJlJ3MgYW55IGVhc3kgc29sdXRpb24sIHdlIGp1c3QgbmVlZCB0byBzdGFydCBh
IHNlcmlvdXMNCmRpc2N1c3Npb24gd2l0aCB0aGUgVENQIG1haW50YWluZXJzIGhvdyB0byBzb2x2
ZSB0aGlzLiBJSVJDIGF0aDEwaw0KZGlkbid0IGhhdmUgdGhpcyBwcm9ibGVtIHVudGlsIHNvbWV0
aGluZyBjaGFuZ2VkIGluIHRoZSBUQ1Agc3RhY2ssIHNvIGluDQp0aGVvcnkgdGhpcyBjb3VsZCBi
ZSBjbGFzc2lmaWVkIGFzIGEgcmVncmVzc2lvbiBpbiB0aGUgVENQIHN0YWNrLiBCdXQNCkknbSBu
b3Qgc3VyZSBhYm91dCB0aGF0IGFuZCBuZWVkIHRvIGNoZWNrIHRoZSBoaXN0b3J5Lg0KDQpCdXQg
d2hhdCB3b3VsZCBiZSBoZWxwZnVsIHRvIGhhdmUgYSBkZXRhaWxlZCBzdW1tYXJ5IG9mIHRoZSBp
c3N1ZSwNCnBvaW50ZXJzIHRvIHBhc3QgZGlzY3Vzc2lvbnMgYW5kIGlkZW50aWZ5IHRoZSBUQ1Ag
Y29tbWl0IHdoaWNoIHN0YXJ0ZWQNCmFsbCB0aGlzIGV0Yy4gSSdsbCB0cnkgdG8gZG8gdGhhdCBi
ZWZvcmUgdGhlIE5ldGRldiAyLjIgYnV0IGxldCdzIHNlZSBpZg0KSSBjYW4gbWFrZSBpdC4gSGVs
cCB3aXRoIHRoYXQgaXMgcmVhbGx5IHdlbGNvbWUuDQoNCi0tIA0KS2FsbGUgVmFsbw==

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-11-01  7:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <5a4860eb-3734-7587-d81f-9c3de6ff11c8@leemhuis.info>
     [not found] ` <46f918c5-b07d-e397-2f3d-8136c7c1a8f3@qti.qualcomm.com>
     [not found]   ` <fa6e3ee2-91b5-a54b-afe3-87f30aac7a48@leemhuis.info>
2017-10-27  9:40     ` ath10k-regression due to "ath10k: fix napi_poll budget overflow" c9353bf483d3 Kalle Valo
2017-10-27 19:01       ` Ryan Hsu
2017-10-29  7:44         ` Kalle Valo
2017-10-29 10:21           ` Thorsten Leemhuis
2017-10-29  7:06   ` ath10k-regression in 4.14: Connections aborts with "failed to extract amsdu: -11" Kalle Valo
     [not found]   ` <74a979dc-f06d-be9d-7c3f-359cd481d16c@leemhuis.info>
2017-10-29  7:27     ` ath10k: Wifi slow on the XPS13 (9360) (QCA6174) Kalle Valo
2017-10-31 15:47       ` Thorsten Leemhuis
2017-11-01  7:25         ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).