From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "silexcommon@gmail.com" <silexcommon@gmail.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
Alagu Sankar <alagusankar@silex-india.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 08/11] ath10k_sdio: common read write
Date: Wed, 4 Oct 2017 09:49:18 +0000 [thread overview]
Message-ID: <87wp4bw8de.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1506793068-27445-9-git-send-email-alagusankar@silex-india.com> (silexcommon@gmail.com's message of "Sat, 30 Sep 2017 23:07:45 +0530")
silexcommon@gmail.com writes:
> From: Alagu Sankar <alagusankar@silex-india.com>
>
> convert different read write functions in sdio hif to bring it under a
> single read-write path. This helps in having a common dma bounce buffer
> implementation. Also helps in address modification that is required
> specific to change in certain mbox addresses of sdio_write.
>
> Signed-off-by: Alagu Sankar <alagusankar@silex-india.com>
This didn't compile for me:
drivers/net/wireless/ath/ath10k/sdio.c:320:12: error: conflicting types for=
'ath10k_sdio_read'
drivers/net/wireless/ath/ath10k/sdio.c:39:12: note: previous declaration of=
'ath10k_sdio_read' was here
drivers/net/wireless/ath/ath10k/sdio.c:365:12: error: conflicting types for=
'ath10k_sdio_write'
drivers/net/wireless/ath/ath10k/sdio.c:41:12: note: previous declaration of=
'ath10k_sdio_write' was here
drivers/net/wireless/ath/ath10k/sdio.c:39:12: warning: 'ath10k_sdio_read' u=
sed but never defined
drivers/net/wireless/ath/ath10k/sdio.c:41:12: warning: 'ath10k_sdio_write' =
used but never defined
gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609
I fixed it like below in the pending branch. But I'll review more
carefully later, I have quite a lot of patches pending right now.
--- a/drivers/net/wireless/ath/ath10k/sdio.c
+++ b/drivers/net/wireless/ath/ath10k/sdio.c
@@ -37,9 +37,9 @@
#define ATH10K_SDIO_DMA_BUF_SIZE (32 * 1024)
=20
static int ath10k_sdio_read(struct ath10k *ar, u32 addr, void *buf,
- u32 len, bool incr);
+ size_t len, bool incr);
static int ath10k_sdio_write(struct ath10k *ar, u32 addr, const void *buf,
- u32 len, bool incr);
+ size_t len, bool incr);
=20
/* inlined helper functions */
--=20
Kalle Valo=
next prev parent reply other threads:[~2017-10-04 9:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 17:37 [PATCH 00/11] SDIO support for ath10k silexcommon
2017-09-30 17:37 ` [PATCH 01/11] ath10k_sdio: sdio htt data transfer fixes silexcommon
2017-10-02 7:36 ` Arend van Spriel
2017-10-02 7:44 ` Alagu Sankar
2017-10-04 8:55 ` Kalle Valo
2017-09-30 17:37 ` [PATCH 02/11] ath10k_sdio: wb396 reference card fix silexcommon
2017-10-01 22:47 ` Steve deRosier
2017-10-02 7:02 ` Alagu Sankar
2017-10-02 9:06 ` Erik Stromdahl
2017-09-30 17:37 ` [PATCH 03/11] ath10k_sdio: DMA bounce buffers for read write silexcommon
2017-12-22 16:08 ` Kalle Valo
2017-12-25 12:26 ` Alagu Sankar
2017-12-25 16:11 ` Adrian Chadd
2017-12-27 18:49 ` Arend van Spriel
2017-12-27 19:26 ` Adrian Chadd
2018-01-08 12:58 ` Kalle Valo
2017-09-30 17:37 ` [PATCH 04/11] ath10k_sdio: reduce transmit msdu count silexcommon
2017-09-30 17:37 ` [PATCH 05/11] ath10k_sdio: use clean packet headers silexcommon
2017-09-30 17:37 ` [PATCH 06/11] ath10k_sdio: high latency fixes for beacon buffer silexcommon
2017-09-30 17:37 ` [PATCH 07/11] ath10k_sdio: fix rssi indication silexcommon
2017-09-30 17:37 ` [PATCH 08/11] ath10k_sdio: common read write silexcommon
2017-10-04 9:49 ` Kalle Valo [this message]
2017-10-05 10:09 ` [08/11] " Gary Bisson
2017-10-05 17:33 ` Alagu Sankar
2017-12-08 14:42 ` Gary Bisson
2017-09-30 17:37 ` [PATCH 09/11] ath10k_sdio: virtual scatter gather for receive silexcommon
2017-10-04 19:56 ` Erik Stromdahl
2017-09-30 17:37 ` [PATCH 10/11] ath10k_sdio: enable firmware crash dump silexcommon
2017-09-30 17:37 ` [PATCH 11/11] ath10k_sdio: hif start once addition silexcommon
2017-10-02 9:02 ` [PATCH 00/11] SDIO support for ath10k Erik Stromdahl
2017-10-04 6:22 ` Alagu Sankar
2017-10-04 15:53 ` Erik Stromdahl
2017-10-05 15:12 ` Gary Bisson
2017-10-05 17:24 ` Alagu Sankar
2017-10-06 11:16 ` Gary Bisson
2017-12-18 16:19 ` Gary Bisson
2017-12-22 16:21 ` Kalle Valo
2017-12-22 16:25 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wp4bw8de.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=alagusankar@silex-india.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=silexcommon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).