From: Kalle Valo <kvalo@codeaurora.org>
To: "Pan\, Miaoqing" <miaoqing@qti.qualcomm.com>
Cc: Stephan Mueller <smueller@chronox.de>, Ted Tso <tytso@mit.edu>,
"Sepehrdad\, Pouyan" <pouyans@qti.qualcomm.com>,
"herbert\@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto\@vger.kernel.org" <linux-crypto@vger.kernel.org>,
ath9k-devel <ath9k-devel@qca.qualcomm.com>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"ath9k-devel\@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
"Jason Cooper" <jason@lakedaemon.net>
Subject: Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy
Date: Mon, 15 Aug 2016 14:01:09 +0300 [thread overview]
Message-ID: <87wpji70ui.fsf@purkki.adurom.net> (raw)
In-Reply-To: <657897b90b8344eeab10d7a0f604988d@aptaiexm02f.ap.qualcomm.com> (Miaoqing Pan's message of "Mon, 8 Aug 2016 02:03:36 +0000")
"Pan, Miaoqing" <miaoqing@qti.qualcomm.com> writes:
> The entropy was evaluated by crypto expert, the analysis report show
> the ADC with at least 10bits and up to 22 bits of min-entropy for a 32
> bits value, we conservatively assume the min-entropy is 10 bits out of
> 32 bits, so that's why set entropy quality to 320/1024 = 10/32. Also
> we have explained in the commit message why can't use the HW RNG
> framework.
>
> Otherwise, your patch will cause high CPU load, as continuously read
> ADC data if entropy bits under write_wakeup_threshold.
Please don't top post, it breaks patchwork which is extremely annoying
for me:
https://patchwork.kernel.org/patch/9266265/
https://patchwork.kernel.org/patch/9266617/
--
Kalle Valo
next prev parent reply other threads:[~2016-08-15 11:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 15:08 [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy Stephan Mueller
2016-08-06 19:45 ` Jason Cooper
2016-08-06 20:03 ` Stephan Mueller
2016-08-06 20:16 ` Jason Cooper
2016-08-07 9:36 ` [PATCH v2] " Stephan Mueller
2016-08-08 2:03 ` Pan, Miaoqing
2016-08-08 6:41 ` Stephan Mueller
2016-08-08 17:29 ` Jason Cooper
2016-08-08 22:04 ` Jason Cooper
2016-08-09 6:30 ` Pan, Miaoqing
2016-08-09 11:56 ` Theodore Ts'o
2016-08-09 14:04 ` Jason Cooper
2016-08-10 23:44 ` Theodore Ts'o
2016-08-14 18:11 ` Jason Cooper
2016-08-15 11:01 ` Kalle Valo [this message]
2016-09-27 14:44 ` [v2] " Kalle Valo
2016-09-27 15:17 ` Stephan Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpji70ui.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=ath9k-devel@lists.ath9k.org \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jason@lakedaemon.net \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing@qti.qualcomm.com \
--cc=pouyans@qti.qualcomm.com \
--cc=smueller@chronox.de \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).