Re: [PATCH v7] Add new mac80211 driver mwlwifi.

[Kalle Valo <kvalo@codeaurora.org>]

Bjørn Mork <bjorn@mork.no> writes:

> David Lin <dlin@marvell.com> writes:
>
>> We felt some resistance from various people, and get discouraged.
>
> Sorry to hear that.  I believe this is a misunderstanding.  I am
> convinced that *everyone* who commented on the driver did so with the
> intention to help getting it merged.

Exactly. Why would we otherwise spend so much time reviewing the driver
if we would not want it included?

> I for one would very much like to see this driver in mainline.  But for
> that to happen, you wil have to:
>  1) create a feature frozen branch for mainline submission
>  2) respond relatively quickly to comments received, posting new
>     versions of the patch set if necessary
>
> The main issue preventing this driver from being merged so far, in my
> view, is that you have continued to add features between each attemt to
> get it merged.  Adding new features is of course not bad, but you should
> do that in another branch *until* the initial version is accepted.

Thanks for the good summary, I think we should even add that to our wiki
as a guideline for new drivers. Then submitting a new driver (or normal
patches for that matter) you really want to optimise the use of
reviewer's time. Just fix the issues pointed out in the review, don't do
anything extra as the chances are that it just slows down everything.

-- 
Kalle Valo