From: Kalle Valo <kvalo@qca.qualcomm.com>
To: "Pan, Miaoqing" <miaoqing@qti.qualcomm.com>
Cc: "miaoqing@codeaurora.org" <miaoqing@codeaurora.org>,
"linville@tuxdriver.com" <linville@tuxdriver.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
ath9k-devel <ath9k-devel@qca.qualcomm.com>
Subject: Re: [PATCH 1/5] ath9k: avoid ANI restart if no trigger
Date: Fri, 15 Jan 2016 11:41:03 +0200 [thread overview]
Message-ID: <87wprb6uz4.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1452847122461.2165@qti.qualcomm.com> (Miaoqing Pan's message of "Fri, 15 Jan 2016 10:38:46 +0200")
"Pan, Miaoqing" <miaoqing@qti.qualcomm.com> writes:
> The commit 54da20d83f0e7fe87b75aec44bc2b1448d119320 ("ath9k_hw:
> improve ANI processing and rx desensitizing parameters") first
> introduced this issue, ath9k_ani_restart() is always be invoked is
> wrong.
Then you should add this to the commit log:
Fixes: 54da20d83f0e ("ath9k_hw: improve ANI processing and rx desensitizing parameters")
Also you need to explain more, especially why you think it's wrong. How
did you notice this? What kind of user visible issue this fixes?
--
Kalle Valo
next prev parent reply other threads:[~2016-01-15 9:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 1:23 [PATCH 0/5] ath9k bug fixes miaoqing
2016-01-15 1:23 ` [PATCH 1/5] ath9k: avoid ANI restart if no trigger miaoqing
2016-01-15 8:00 ` Kalle Valo
2016-01-15 8:38 ` Pan, Miaoqing
2016-01-15 9:41 ` Kalle Valo [this message]
2016-01-15 11:28 ` Felix Fietkau
2016-01-15 1:23 ` [PATCH 2/5] ath9k: clean up ANI per-channel pointer checking miaoqing
2016-01-15 1:23 ` [PATCH 3/5] ath9k: do not reset while BB panic(0x4000409) on ar9561 miaoqing
2016-01-15 1:23 ` [PATCH 4/5] ath9k: fix inconsistent use of tab and space in indentation miaoqing
2016-01-15 1:23 ` [PATCH 5/5] ath9k: fix data bus error on ar9300 and ar9580 miaoqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wprb6uz4.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=miaoqing@codeaurora.org \
--cc=miaoqing@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).