Re: [PATCH v2] ath10k: add FW API support to test mode

[Kalle Valo <kvalo@qca.qualcomm.com>]

Michal Kazior <michal.kazior@tieto.com> writes:

>> Hmmm, this way we will have a unified firmware parsing logic. Is this a task
>> which can be taken up easily or any other hidden complexities are invloved
>> ?.
>
> Decoupling the parsing logic should be rather easy. I don't think
> there are any gotchas.

I agree.

>> I mean can we do the changes for current parsing logic and then rework the
>> test mode patch ? what is your suggestion ?
>
> If you want to do the unified parsing logic approach you should first
> decouple the logic (i.e. make it not fill `struct ath10k` directly)
> and then rework the testmode patch on top of that.

Actually I prefer the other way around, I can first apply the test mode
patch and later someone can decouple the logic in a new patch. The code
size benefits that from all pretty small so I don't think it's sensible
to delay this patch. But decoupling the logic would be nice cleanup to
do.

-- 
Kalle Valo