linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Zhao\, Gang" <gamerh2o@gmail.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] wlan-ng: fixup staging driver for removal of ieee80211_dsss_chan_to_freq
Date: Sat, 15 Mar 2014 12:39:14 +0800	[thread overview]
Message-ID: <87wqfw6pot.fsf@will.lan> (raw)
In-Reply-To: <1394730975-20389-1-git-send-email-linville@tuxdriver.com> (John W. Linville's message of "Thu, 13 Mar 2014 13:16:15 -0400")

On Fri, 2014-03-14 at 01:16:15 +0800, John W. Linville wrote:
> Commit 3ebe8e257307a87c33460aa7d2b75dadd374ed9c ("ieee80211: remove
> function ieee80211_{dsss_chan_to_freq, freq_to_dsss_chan}") removed
> ieee80211_dsss_chan_to_freq, but it neglected to account for this
> staging driver...

Hi, John.

I have submited a similar patch to staging/staging-next tree, and it was
applied in that tree on Feb 18, the commit is 4e5e9d7c66f04 on that
tree. But my patch add a variable to deal with 80 characters
problem. I'm not sure if your patch is applied to wireless-next, then
there could be a conflict in future time.

I separated the wireless tree patches and staging tree patch to
different maintainers when doing that change. If I knew the staging driver
change can happen on wireless tree, I should have combined them in one place.

>
> Cc: Zhao, Gang <gamerh2o@gmail.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index a7d24c95191d..7dd2b95416e8 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -416,7 +416,7 @@ static int prism2_scan(struct wiphy *wiphy,
>  		memcpy(&ie_buf[2], &(msg2.ssid.data.data), msg2.ssid.data.len);
>  		bss = cfg80211_inform_bss(wiphy,
>  			ieee80211_get_channel(wiphy,
> -			      ieee80211_dsss_chan_to_freq(msg2.dschannel.data)),
> +			      ieee80211_channel_to_frequency(msg2.dschannel.data, IEEE80211_BAND_2GHZ)),
>  			(const u8 *) &(msg2.bssid.data.data),
>  			msg2.timestamp.data, msg2.capinfo.data,
>  			msg2.beaconperiod.data,

      reply	other threads:[~2014-03-15  4:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-13 17:16 [PATCH] wlan-ng: fixup staging driver for removal of ieee80211_dsss_chan_to_freq John W. Linville
2014-03-15  4:39 ` Zhao, Gang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wqfw6pot.fsf@will.lan \
    --to=gamerh2o@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).