From: Kalle Valo <kalle.valo@iki.fi>
To: Roel Kluin <roel.kluin@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] wl12xx: loop off by one.
Date: Thu, 16 Jul 2009 16:44:35 +0300 [thread overview]
Message-ID: <87ws684u9o.fsf@litku.valot.fi> (raw)
In-Reply-To: <4A5F02C9.50505@gmail.com> (Roel Kluin's message of "Thu\, 16 Jul 2009 12\:36\:57 +0200")
Roel Kluin <roel.kluin@gmail.com> writes:
> With `while (loop++ < INIT_LOOP)' `loop' becomes INIT_LOOP + 1 after
> the loop.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
>>> with `while (loop++ < INIT_LOOP)' `loop' reaches -1 after the loop.
>>
>> Sorry, my brains are on vacation mode right now and I can't understand
>> how loop can reach -1.
>
> The confusion is my fault. The changelog should have as above. The patch
> is correct though.
Ah. Thanks for explaining this to me, I understand this now. Good catch,
thanks for fixing this.
Acked-by: Kalle Valo <kalle.valo@nokia.com>
John, please take this patch. Please holler if we need to resend it.
--
Kalle Valo
prev parent reply other threads:[~2009-07-16 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 19:20 [PATCH] wl12xx: loop off by one Roel Kluin
2009-07-16 9:23 ` Kalle Valo
2009-07-16 10:36 ` Roel Kluin
2009-07-16 13:44 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ws684u9o.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=akpm@linux-foundation.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).