From: Kalle Valo <kalle.valo@nokia.com>
To: Jouni Malinen <j@w1.fi>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] mac80211: don't drop null frames during software scan
Date: Mon, 16 Mar 2009 14:36:46 +0200 [thread overview]
Message-ID: <87wsaptzj5.fsf@nokia.com> (raw)
In-Reply-To: <871vsxve5p.fsf@nokia.com> (Kalle Valo's message of "Mon\, 16 Mar 2009 14\:35\:30 +0200")
Kalle Valo <kalle.valo@nokia.com> writes:
>> so this should not matter much, but the comment could be made more
>> clear about the different needs for nullfunc frames (please also
>> s/null frames/nullfunc frames/) and probe request frames. The former
>> are sent only on the operational channel in the beginning and end of
>> scan while the latter are sent on the channels to be scanned during
>> an active scan.
>
> Should the description be in ieee80211_start_scan() in scan.c? I think
> it would make more sense to have it there instead of tx.c. I can then
> add a reference to the comment above.
Oh yeah, forgot to mention that I'll use the term "nullfunc frame" in
v3.
--
Kalle Valo
next prev parent reply other threads:[~2009-03-16 12:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-15 20:07 [PATCH v2] mac80211: don't drop null frames during software scan Kalle Valo
2009-03-16 8:57 ` Jouni Malinen
2009-03-16 12:35 ` Kalle Valo
2009-03-16 12:36 ` Kalle Valo [this message]
2009-03-16 18:50 ` Jouni Malinen
2009-03-16 14:00 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wsaptzj5.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=j@w1.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).