linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"konstantin.kletschke@inside-m2m.de"
	<konstantin.kletschke@inside-m2m.de>
Subject: Re: AP mode on RTW88 8821cs
Date: Tue, 26 Mar 2024 17:47:07 +0200	[thread overview]
Message-ID: <87y1a56lms.fsf@kernel.org> (raw)
In-Reply-To: <2fcab17428576577cbf47bc9551c44f5bac0ea95.camel@realtek.com> (Ping-Ke Shih's message of "Tue, 26 Mar 2024 01:57:05 +0000")

Ping-Ke Shih <pkshih@realtek.com> writes:

> On Fri, 2024-03-22 at 17:36 +0200, Kalle Valo wrote:
>> 
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>> 
>> > We had similar discussion before [1]. I think Martin will take his time to
>> > investigate how to enable AP mode on SDIO WiFi cards.
>> > 
>> > [1]
>> > https://lore.kernel.org/linux-wireless/36972ff5-0c48-4bd2-8f9a-9649bfa24225@lexina.in/
>> 
>> If AP mode is broken on SDIO devices it would be user friendly to
>> disable AP mode support (NL80211_IFTYPE_AP in wiphy->interface_modes) on
>> SDIO until the issues are fixed. In other words, the driver should only
>> enable features which work reliably.
>> 
>
> I made a patch [1] to set station mode only for SDIO devices.

Very nice, thanks Ping.

> Meanwhile, I would like to remove mesh point support from rtw88
> because I don't have impression that it can work and someone uses
> that.

Yeah, if you are not 100% sure that mesh works then it's better to
remove it from rtw88. If out of some miracle the mesh mode would
actually work, I'm sure someone will then report that to us and we can
add it back to rtw88.

      reply	other threads:[~2024-03-26 15:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21 10:55 AP mode on RTW88 8821cs Konstantin Kletschke
2024-03-22  0:16 ` Ping-Ke Shih
2024-03-22 13:04   ` Konstantin Kletschke
2024-03-22 15:36   ` Kalle Valo
2024-03-26  1:57     ` Ping-Ke Shih
2024-03-26 15:47       ` Kalle Valo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y1a56lms.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=konstantin.kletschke@inside-m2m.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).