From: Kalle Valo <kvalo@kernel.org>
To: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
Felix Fietkau <nbd@nbd.name>,
Felipe Negrelli Wolter <felipe.negrelliwolter@silabs.com>,
Olivier Souloumiac <olivier.souloumiac@silabs.com>,
Alexandr Suslenko <suslenko.o@ajax.systems>
Subject: Re: [PATCH v2] wifi: wfx: fix case where rates are out of order
Date: Wed, 04 Oct 2023 16:22:12 +0300 [thread overview]
Message-ID: <87y1gi5xq3.fsf@kernel.org> (raw)
In-Reply-To: <2534699.vzjCzTo3RI@pc-42> ("Jérôme Pouiller"'s message of "Wed, 04 Oct 2023 15:00:49 +0200")
Jérôme Pouiller <jerome.pouiller@silabs.com> writes:
>> > v2:
>> > - Fix malformed tags in commit body. (checkpatch still complains about
>> > missing Close tag, but the bug tracker is not public and I don't have
>> > the exact URL)
>>
>> Just out of curiosity why does the checkpatch complain about a missing
>> Close tag? I don't get it why there should be one.
>
> I am on top of v6.6-rc3. I get:
>
> $ ./scripts/checkpatch.pl -g HEAD^..HEAD
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #26:
> best ____________rate__________ ____statistics___ _____last____ ______sum-of________
>
> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report
> #57:
> Reported-by: Alexandr Suslenko <suslenko.o@ajax.systems>
> Co-developed-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
> [...]
Ah, thanks. Now I understand. But that rule doesn't make any sense to
me, for example I get reports privately as well and add a Reported-by
without a Closes tag. So always feel free to ignore that checkpatch
warning.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-10-04 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-04 12:30 [PATCH v2] wifi: wfx: fix case where rates are out of order Jérôme Pouiller
2023-10-04 12:57 ` Kalle Valo
2023-10-04 13:00 ` Jérôme Pouiller
2023-10-04 13:22 ` Kalle Valo [this message]
2023-10-09 6:54 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1gi5xq3.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=felipe.negrelliwolter@silabs.com \
--cc=jerome.pouiller@silabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=olivier.souloumiac@silabs.com \
--cc=suslenko.o@ajax.systems \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox