* [PATCH 1/3] wifi: ath10k: Fix a few spelling errors
2023-08-22 14:50 [PATCH 0/3] ath*: Fix a few spelling errors Jeff Johnson
@ 2023-08-22 14:50 ` Jeff Johnson
2023-08-22 16:14 ` Randy Dunlap
2023-08-23 14:06 ` Kalle Valo
2023-08-22 14:50 ` [PATCH 2/3] wifi: ath11k: " Jeff Johnson
2023-08-22 14:50 ` [PATCH 3/3] wifi: ath12k: " Jeff Johnson
2 siblings, 2 replies; 10+ messages in thread
From: Jeff Johnson @ 2023-08-22 14:50 UTC (permalink / raw)
To: Kalle Valo, Jeff Johnson
Cc: ath10k, linux-wireless, linux-kernel, ath11k, ath12k
Fix a few issues flagged by 'codespell'.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/net/wireless/ath/ath10k/htt.h | 4 ++--
drivers/net/wireless/ath/ath10k/pci.c | 2 +-
drivers/net/wireless/ath/ath10k/sdio.c | 2 +-
drivers/net/wireless/ath/ath10k/wmi.h | 8 ++++----
4 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
index e0c9f45e7476..7b24297146e7 100644
--- a/drivers/net/wireless/ath/ath10k/htt.h
+++ b/drivers/net/wireless/ath/ath10k/htt.h
@@ -69,7 +69,7 @@ struct htt_ver_req {
* The HTT tx descriptor is defined in two manners: by a struct with
* bitfields, and by a series of [dword offset, bit mask, bit shift]
* definitions.
- * The target should use the struct def, for simplicitly and clarity,
+ * The target should use the struct def, for simplicity and clarity,
* but the host shall use the bit-mast + bit-shift defs, to be endian-
* neutral. Specifically, the host shall use the get/set macros built
* around the mask + shift defs.
@@ -2086,7 +2086,7 @@ static inline bool ath10k_htt_rx_proc_rx_frag_ind(struct ath10k_htt *htt,
* for correctly accessing rx descriptor data.
*/
-/* base struct used for abstracting the rx descritor representation */
+/* base struct used for abstracting the rx descriptor representation */
struct htt_rx_desc {
union {
/* This field is filled on the host using the msdu buffer
diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c
index a7f44f6335fb..57177890a463 100644
--- a/drivers/net/wireless/ath/ath10k/pci.c
+++ b/drivers/net/wireless/ath/ath10k/pci.c
@@ -1636,7 +1636,7 @@ static int ath10k_pci_dump_memory_generic(struct ath10k *ar,
buf,
current_region->len);
- /* No individiual memory sections defined so we can
+ /* No individual memory sections defined so we can
* copy the entire memory region.
*/
ret = ath10k_pci_diag_read_mem(ar,
diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c
index 79e09c7a82b3..56fbcfb80bf8 100644
--- a/drivers/net/wireless/ath/ath10k/sdio.c
+++ b/drivers/net/wireless/ath/ath10k/sdio.c
@@ -2389,7 +2389,7 @@ static int ath10k_sdio_dump_memory_generic(struct ath10k *ar,
buf,
current_region->len);
- /* No individiual memory sections defined so we can
+ /* No individual memory sections defined so we can
* copy the entire memory region.
*/
if (fast_dump)
diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index 6d04a66fe5e0..b112e8826093 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -3854,9 +3854,9 @@ enum wmi_pdev_param {
* retransmitting frames.
*/
WMI_PDEV_PARAM_DYNAMIC_BW,
- /* Non aggregrate/ 11g sw retry threshold.0-disable */
+ /* Non aggregate/ 11g sw retry threshold.0-disable */
WMI_PDEV_PARAM_NON_AGG_SW_RETRY_TH,
- /* aggregrate sw retry threshold. 0-disable*/
+ /* aggregate sw retry threshold. 0-disable*/
WMI_PDEV_PARAM_AGG_SW_RETRY_TH,
/* Station kickout threshold (non of consecutive failures).0-disable */
WMI_PDEV_PARAM_STA_KICKOUT_TH,
@@ -3953,9 +3953,9 @@ enum wmi_10x_pdev_param {
WMI_10X_PDEV_PARAM_PROTECTION_MODE,
/* Dynamic bandwidth 0: disable 1: enable */
WMI_10X_PDEV_PARAM_DYNAMIC_BW,
- /* Non aggregrate/ 11g sw retry threshold.0-disable */
+ /* Non aggregate/ 11g sw retry threshold.0-disable */
WMI_10X_PDEV_PARAM_NON_AGG_SW_RETRY_TH,
- /* aggregrate sw retry threshold. 0-disable*/
+ /* aggregate sw retry threshold. 0-disable*/
WMI_10X_PDEV_PARAM_AGG_SW_RETRY_TH,
/* Station kickout threshold (non of consecutive failures).0-disable */
WMI_10X_PDEV_PARAM_STA_KICKOUT_TH,
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/3] wifi: ath10k: Fix a few spelling errors
2023-08-22 14:50 ` [PATCH 1/3] wifi: ath10k: " Jeff Johnson
@ 2023-08-22 16:14 ` Randy Dunlap
2023-08-23 14:06 ` Kalle Valo
1 sibling, 0 replies; 10+ messages in thread
From: Randy Dunlap @ 2023-08-22 16:14 UTC (permalink / raw)
To: Jeff Johnson, Kalle Valo
Cc: ath10k, linux-wireless, linux-kernel, ath11k, ath12k
On 8/22/23 07:50, Jeff Johnson wrote:
> Fix a few issues flagged by 'codespell'.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/net/wireless/ath/ath10k/htt.h | 4 ++--
> drivers/net/wireless/ath/ath10k/pci.c | 2 +-
> drivers/net/wireless/ath/ath10k/sdio.c | 2 +-
> drivers/net/wireless/ath/ath10k/wmi.h | 8 ++++----
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] wifi: ath10k: Fix a few spelling errors
2023-08-22 14:50 ` [PATCH 1/3] wifi: ath10k: " Jeff Johnson
2023-08-22 16:14 ` Randy Dunlap
@ 2023-08-23 14:06 ` Kalle Valo
1 sibling, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2023-08-23 14:06 UTC (permalink / raw)
To: Jeff Johnson
Cc: Jeff Johnson, ath10k, linux-wireless, linux-kernel, ath11k,
ath12k
Jeff Johnson <quic_jjohnson@quicinc.com> wrote:
> Fix a few issues flagged by 'codespell'.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
3 patches applied to ath-next branch of ath.git, thanks.
3ced39049d4d wifi: ath10k: Fix a few spelling errors
d68a283bfc39 wifi: ath11k: Fix a few spelling errors
4f1dbb4904c3 wifi: ath12k: Fix a few spelling errors
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230822-ath_spelling-v1-1-8e2698759564@quicinc.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] wifi: ath11k: Fix a few spelling errors
2023-08-22 14:50 [PATCH 0/3] ath*: Fix a few spelling errors Jeff Johnson
2023-08-22 14:50 ` [PATCH 1/3] wifi: ath10k: " Jeff Johnson
@ 2023-08-22 14:50 ` Jeff Johnson
2023-08-22 16:16 ` Randy Dunlap
2023-08-22 14:50 ` [PATCH 3/3] wifi: ath12k: " Jeff Johnson
2 siblings, 1 reply; 10+ messages in thread
From: Jeff Johnson @ 2023-08-22 14:50 UTC (permalink / raw)
To: Kalle Valo, Jeff Johnson
Cc: ath10k, linux-wireless, linux-kernel, ath11k, ath12k
Fix a few issues flagged by 'codespell'.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/net/wireless/ath/ath11k/dp.h | 2 +-
drivers/net/wireless/ath/ath11k/dp_rx.c | 2 +-
drivers/net/wireless/ath/ath11k/dp_tx.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath11k/dp.h b/drivers/net/wireless/ath/ath11k/dp.h
index d04f78ab6b37..15815af453b2 100644
--- a/drivers/net/wireless/ath/ath11k/dp.h
+++ b/drivers/net/wireless/ath/ath11k/dp.h
@@ -635,7 +635,7 @@ enum htt_ppdu_stats_tag_type {
* b'24 - status_swap: 1 is to swap status TLV
* b'25 - pkt_swap: 1 is to swap packet TLV
* b'26:31 - rsvd1: reserved for future use
- * dword1 - b'0:16 - ring_buffer_size: size of bufferes referenced by rx ring,
+ * dword1 - b'0:16 - ring_buffer_size: size of buffers referenced by rx ring,
* in byte units.
* Valid only for HW_TO_SW_RING and SW_TO_HW_RING
* - b'16:31 - rsvd2: Reserved for future use
diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index 1e488eed282b..62bc98852f0f 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -3423,7 +3423,7 @@ static int ath11k_dp_rx_h_defrag_reo_reinject(struct ath11k *ar, struct dp_rx_ti
ath11k_hal_rx_buf_addr_info_set(msdu0, paddr, cookie,
ab->hw_params.hal_params->rx_buf_rbm);
- /* Fill mpdu details into reo entrace ring */
+ /* Fill mpdu details into reo entrance ring */
srng = &ab->hal.srng_list[ab->dp.reo_reinject_ring.ring_id];
spin_lock_bh(&srng->lock);
diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c
index a34833de7c67..352e76fc4c1f 100644
--- a/drivers/net/wireless/ath/ath11k/dp_tx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
@@ -238,7 +238,7 @@ int ath11k_dp_tx(struct ath11k *ar, struct ath11k_vif *arvif,
spin_unlock_bh(&tcl_ring->lock);
ret = -ENOMEM;
- /* Checking for available tcl descritors in another ring in
+ /* Checking for available tcl descriptors in another ring in
* case of failure due to full tcl ring now, is better than
* checking this ring earlier for each pkt tx.
* Restart ring selection if some rings are not checked yet.
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH 3/3] wifi: ath12k: Fix a few spelling errors
2023-08-22 14:50 [PATCH 0/3] ath*: Fix a few spelling errors Jeff Johnson
2023-08-22 14:50 ` [PATCH 1/3] wifi: ath10k: " Jeff Johnson
2023-08-22 14:50 ` [PATCH 2/3] wifi: ath11k: " Jeff Johnson
@ 2023-08-22 14:50 ` Jeff Johnson
2023-08-22 16:18 ` Randy Dunlap
2 siblings, 1 reply; 10+ messages in thread
From: Jeff Johnson @ 2023-08-22 14:50 UTC (permalink / raw)
To: Kalle Valo, Jeff Johnson
Cc: ath10k, linux-wireless, linux-kernel, ath11k, ath12k
Fix a few issues flagged by 'codespell'.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/net/wireless/ath/ath12k/dp.h | 2 +-
drivers/net/wireless/ath/ath12k/dp_rx.c | 2 +-
drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +-
drivers/net/wireless/ath/ath12k/mac.c | 2 +-
drivers/net/wireless/ath/ath12k/rx_desc.h | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/dp.h b/drivers/net/wireless/ath/ath12k/dp.h
index 7c5dafce5a68..6e7b7281d549 100644
--- a/drivers/net/wireless/ath/ath12k/dp.h
+++ b/drivers/net/wireless/ath/ath12k/dp.h
@@ -712,7 +712,7 @@ enum htt_stats_internal_ppdu_frametype {
* b'24 - status_swap: 1 is to swap status TLV
* b'25 - pkt_swap: 1 is to swap packet TLV
* b'26:31 - rsvd1: reserved for future use
- * dword1 - b'0:16 - ring_buffer_size: size of bufferes referenced by rx ring,
+ * dword1 - b'0:16 - ring_buffer_size: size of buffers referenced by rx ring,
* in byte units.
* Valid only for HW_TO_SW_RING and SW_TO_HW_RING
* - b'16:31 - rsvd2: Reserved for future use
diff --git a/drivers/net/wireless/ath/ath12k/dp_rx.c b/drivers/net/wireless/ath/ath12k/dp_rx.c
index 67f8c140840f..e6e64d437c47 100644
--- a/drivers/net/wireless/ath/ath12k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_rx.c
@@ -3027,7 +3027,7 @@ static int ath12k_dp_rx_h_defrag_reo_reinject(struct ath12k *ar,
desc_info->cookie,
HAL_RX_BUF_RBM_SW3_BM);
- /* Fill mpdu details into reo entrace ring */
+ /* Fill mpdu details into reo entrance ring */
srng = &ab->hal.srng_list[dp->reo_reinject_ring.ring_id];
spin_lock_bh(&srng->lock);
diff --git a/drivers/net/wireless/ath/ath12k/dp_tx.c b/drivers/net/wireless/ath/ath12k/dp_tx.c
index d661fe586651..8874c815d7fa 100644
--- a/drivers/net/wireless/ath/ath12k/dp_tx.c
+++ b/drivers/net/wireless/ath/ath12k/dp_tx.c
@@ -301,7 +301,7 @@ int ath12k_dp_tx(struct ath12k *ar, struct ath12k_vif *arvif,
spin_unlock_bh(&tcl_ring->lock);
ret = -ENOMEM;
- /* Checking for available tcl descritors in another ring in
+ /* Checking for available tcl descriptors in another ring in
* case of failure due to full tcl ring now, is better than
* checking this ring earlier for each pkt tx.
* Restart ring selection if some rings are not checked yet.
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
index 0f2af2f14ef7..dbaf033c2527 100644
--- a/drivers/net/wireless/ath/ath12k/mac.c
+++ b/drivers/net/wireless/ath/ath12k/mac.c
@@ -6771,7 +6771,7 @@ ath12k_mac_op_reconfig_complete(struct ieee80211_hw *hw,
/* After trigger disconnect, then upper layer will
* trigger connect again, then the PN number of
* upper layer will be reset to keep up with AP
- * side, hence PN number mis-match will not happened.
+ * side, hence PN number mismatch will not happened.
*/
if (arvif->is_up &&
arvif->vdev_type == WMI_VDEV_TYPE_STA &&
diff --git a/drivers/net/wireless/ath/ath12k/rx_desc.h b/drivers/net/wireless/ath/ath12k/rx_desc.h
index f99556a253e5..bfa87cb8d021 100644
--- a/drivers/net/wireless/ath/ath12k/rx_desc.h
+++ b/drivers/net/wireless/ath/ath12k/rx_desc.h
@@ -221,7 +221,7 @@ struct rx_mpdu_start_qcn9274 {
* PPE routing even if RXOLE CCE or flow search indicate 'Use_PPE'
* This is set by SW for peers which are being handled by a
* host SW/accelerator subsystem that also handles packet
- * uffer management for WiFi-to-PPE routing.
+ * buffer management for WiFi-to-PPE routing.
*
* This is cleared by SW for peers which are being handled
* by a different subsystem, completely disabling WiFi-to-PPE
--
2.25.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 3/3] wifi: ath12k: Fix a few spelling errors
2023-08-22 14:50 ` [PATCH 3/3] wifi: ath12k: " Jeff Johnson
@ 2023-08-22 16:18 ` Randy Dunlap
2023-08-22 16:43 ` Jeff Johnson
0 siblings, 1 reply; 10+ messages in thread
From: Randy Dunlap @ 2023-08-22 16:18 UTC (permalink / raw)
To: Jeff Johnson, Kalle Valo
Cc: ath10k, linux-wireless, linux-kernel, ath11k, ath12k
Hi--
On 8/22/23 07:50, Jeff Johnson wrote:
> Fix a few issues flagged by 'codespell'.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/net/wireless/ath/ath12k/dp.h | 2 +-
> drivers/net/wireless/ath/ath12k/dp_rx.c | 2 +-
> drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +-
> drivers/net/wireless/ath/ath12k/mac.c | 2 +-
> drivers/net/wireless/ath/ath12k/rx_desc.h | 2 +-
> 5 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
> index 0f2af2f14ef7..dbaf033c2527 100644
> --- a/drivers/net/wireless/ath/ath12k/mac.c
> +++ b/drivers/net/wireless/ath/ath12k/mac.c
> @@ -6771,7 +6771,7 @@ ath12k_mac_op_reconfig_complete(struct ieee80211_hw *hw,
> /* After trigger disconnect, then upper layer will
> * trigger connect again, then the PN number of
> * upper layer will be reset to keep up with AP
> - * side, hence PN number mis-match will not happened.
> + * side, hence PN number mismatch will not happened.
The fix is good, but preferably also s/happened/happen/.
> */
> if (arvif->is_up &&
> arvif->vdev_type == WMI_VDEV_TYPE_STA &&
--
~Randy
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] wifi: ath12k: Fix a few spelling errors
2023-08-22 16:18 ` Randy Dunlap
@ 2023-08-22 16:43 ` Jeff Johnson
2023-08-22 19:10 ` Kalle Valo
0 siblings, 1 reply; 10+ messages in thread
From: Jeff Johnson @ 2023-08-22 16:43 UTC (permalink / raw)
To: Randy Dunlap, Kalle Valo
Cc: ath10k, linux-wireless, linux-kernel, ath11k, ath12k
On 8/22/2023 9:18 AM, Randy Dunlap wrote:
> Hi--
>
> On 8/22/23 07:50, Jeff Johnson wrote:
>> Fix a few issues flagged by 'codespell'.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> drivers/net/wireless/ath/ath12k/dp.h | 2 +-
>> drivers/net/wireless/ath/ath12k/dp_rx.c | 2 +-
>> drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +-
>> drivers/net/wireless/ath/ath12k/mac.c | 2 +-
>> drivers/net/wireless/ath/ath12k/rx_desc.h | 2 +-
>> 5 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
>> index 0f2af2f14ef7..dbaf033c2527 100644
>> --- a/drivers/net/wireless/ath/ath12k/mac.c
>> +++ b/drivers/net/wireless/ath/ath12k/mac.c
>> @@ -6771,7 +6771,7 @@ ath12k_mac_op_reconfig_complete(struct ieee80211_hw *hw,
>> /* After trigger disconnect, then upper layer will
>> * trigger connect again, then the PN number of
>> * upper layer will be reset to keep up with AP
>> - * side, hence PN number mis-match will not happened.
>> + * side, hence PN number mismatch will not happened.
>
> The fix is good, but preferably also s/happened/happen/.
Kalle, can you apply that when it goes to -pending?
>
>> */
>> if (arvif->is_up &&
>> arvif->vdev_type == WMI_VDEV_TYPE_STA &&
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] wifi: ath12k: Fix a few spelling errors
2023-08-22 16:43 ` Jeff Johnson
@ 2023-08-22 19:10 ` Kalle Valo
0 siblings, 0 replies; 10+ messages in thread
From: Kalle Valo @ 2023-08-22 19:10 UTC (permalink / raw)
To: Jeff Johnson
Cc: Randy Dunlap, ath10k, linux-wireless, linux-kernel, ath11k,
ath12k
Jeff Johnson <quic_jjohnson@quicinc.com> writes:
> On 8/22/2023 9:18 AM, Randy Dunlap wrote:
>
>> Hi--
>> On 8/22/23 07:50, Jeff Johnson wrote:
>>> Fix a few issues flagged by 'codespell'.
>>>
>>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>>> ---
>>> drivers/net/wireless/ath/ath12k/dp.h | 2 +-
>>> drivers/net/wireless/ath/ath12k/dp_rx.c | 2 +-
>>> drivers/net/wireless/ath/ath12k/dp_tx.c | 2 +-
>>> drivers/net/wireless/ath/ath12k/mac.c | 2 +-
>>> drivers/net/wireless/ath/ath12k/rx_desc.h | 2 +-
>>> 5 files changed, 5 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
>>> index 0f2af2f14ef7..dbaf033c2527 100644
>>> --- a/drivers/net/wireless/ath/ath12k/mac.c
>>> +++ b/drivers/net/wireless/ath/ath12k/mac.c
>>> @@ -6771,7 +6771,7 @@ ath12k_mac_op_reconfig_complete(struct ieee80211_hw *hw,
>>> /* After trigger disconnect, then upper layer will
>>> * trigger connect again, then the PN number of
>>> * upper layer will be reset to keep up with AP
>>> - * side, hence PN number mis-match will not happened.
>>> + * side, hence PN number mismatch will not happened.
>> The fix is good, but preferably also s/happened/happen/.
>
> Kalle, can you apply that when it goes to -pending?
Yes, did that now:
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=212796e28fe44c0a4956c797d8b685b905784cd6
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 10+ messages in thread