From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC69EB64D9 for ; Thu, 15 Jun 2023 12:27:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240110AbjFOM1G (ORCPT ); Thu, 15 Jun 2023 08:27:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240094AbjFOM1C (ORCPT ); Thu, 15 Jun 2023 08:27:02 -0400 Received: from mail.toke.dk (mail.toke.dk [45.145.95.4]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E443D1FE5 for ; Thu, 15 Jun 2023 05:26:58 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1686832016; bh=p2JLR7eyq01/9LwarS3LHAUpoOAFYw45kGwkior1nBQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=wZaYxj4t35pT4fSuD75cWoRyumlNt1uky7QihvJZ9XfDNtr7RXz/M8yX9GkKfFe23 qFCjstYDZfADu4JBSaZjE9lha5hQ5fB9RNJc9GBiDkLqhrQemu8sdn5bY8TLArP1+e IoNdDaoTTLwbr8pvv5tFs36eiXt7EMzWNJS28S9KbAjkHzcqrJkknQMDb5hPzPyiuq B52fAsW+iBpFkv+ByvGFra8d7i+80Y3ONHxF/3XPbIZmI0APcvPfMQ96SUs5dwXrWZ Pd1YJuc0ApZtuLg9RF6AI4o5uWPaw4WE/XeXfeNFM41oB4OidSZH+Gx2jPvNuXp9XJ Ozw8hJ/mnSZaw== To: Kalle Valo Cc: Dmitry Antipov , linux-wireless@vger.kernel.org Subject: Re: [PATCH] wifi: ath9k: convert msecs to jiffies where needed In-Reply-To: <878rcmf7jt.fsf@kernel.org> References: <20230613134655.248728-1-dmantipov@yandex.ru> <87y1knw7ng.fsf@toke.dk> <87pm5yd3rz.fsf@kernel.org> <87a5x2l1bt.fsf@toke.dk> <878rcmf7jt.fsf@kernel.org> Date: Thu, 15 Jun 2023 14:26:55 +0200 X-Clacks-Overhead: GNU Terry Pratchett Message-ID: <87y1kkgbcg.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kalle Valo writes: > Toke H=C3=B8iland-J=C3=B8rgensen writes: > >> Kalle Valo writes: >> >>> Toke H=C3=B8iland-J=C3=B8rgensen writes: >>> >>>> Dmitry Antipov writes: >>>> >>>>> Since 'ieee80211_queue_delayed_work()' expects timeout in >>>>> jiffies and not milliseconds, 'msecs_to_jiffies()' should >>>>> be used in 'ath_restart_work()' and '__ath9k_flush()'. >>>>> >>>>> Signed-off-by: Dmitry Antipov >>>> >>>> I believe this warrants a: >>>> >>>> Fixes: d63ffc45c5d3 ("ath9k: rename tx_complete_work to hw_check_work") >>> >>> I can add that. >> >> I was hoping you'd say that - thanks :) > > BTW you can always assume that I can change or fix the commit messages. > Just let me know exactly what to change, being able to copy paste is > best :) ACK :) -Toke