From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Gregory Erwin <gregerwin256@gmail.com>,
Kalle Valo <kvalo@kernel.org>,
Rui Salvaterra <rsalvaterra@gmail.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
stable@vger.kernel.org
Subject: Re: [PATCH v6] ath9k: sleep for less time when unregistering hwrng
Date: Tue, 28 Jun 2022 12:45:10 +0200 [thread overview]
Message-ID: <87y1xh9idl.fsf@toke.dk> (raw)
In-Reply-To: <20220627120735.611821-1-Jason@zx2c4.com>
"Jason A. Donenfeld" <Jason@zx2c4.com> writes:
> Even though hwrng provides a `wait` parameter, it doesn't work very well
> when waiting for a long time. There are numerous deadlocks that emerge
> related to shutdown. Work around this API limitation by waiting for a
> shorter amount of time and erroring more frequently. This commit also
> prevents hwrng from splatting messages to dmesg when there's a timeout
> and switches to using schedule_timeout_interruptible(), so that the
> kthread can be stopped.
>
> Reported-by: Gregory Erwin <gregerwin256@gmail.com>
> Tested-by: Gregory Erwin <gregerwin256@gmail.com>
> Cc: Toke Høiland-Jørgensen <toke@redhat.com>
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: Rui Salvaterra <rsalvaterra@gmail.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: stable@vger.kernel.org
> Fixes: fcd09c90c3c5 ("ath9k: use hw_random API instead of directly dumping into random.c")
> Link: https://lore.kernel.org/all/CAO+Okf6ZJC5-nTE_EJUGQtd8JiCkiEHytGgDsFGTEjs0c00giw@mail.gmail.com/
> Link: https://lore.kernel.org/lkml/CAO+Okf5k+C+SE6pMVfPf-d8MfVPVq4PO7EY8Hys_DVXtent3HA@mail.gmail.com/
> Link: https://bugs.archlinux.org/task/75138
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Acked-by: Toke Høiland-Jørgensen <toke@toke.dk>
prev parent reply other threads:[~2022-06-28 10:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 5:08 ath9k: hwrng blocks for several minutes when phy is un-associated Gregory Erwin
2022-06-23 12:14 ` Jason A. Donenfeld
2022-06-23 12:16 ` Jason A. Donenfeld
2022-06-23 23:36 ` Gregory Erwin
2022-06-23 23:47 ` Jason A. Donenfeld
2022-06-24 0:01 ` Jason A. Donenfeld
2022-06-24 0:50 ` Jason A. Donenfeld
2022-06-24 1:14 ` [PATCH] ath9k: rng: escape sleep loop when unregistering Jason A. Donenfeld
2022-06-24 5:25 ` Gregory Erwin
2022-06-24 19:12 ` Jason A. Donenfeld
2022-06-24 20:44 ` [PATCH v2] ath9k: sleep for less time when unregistering hwrng Jason A. Donenfeld
2022-06-25 0:13 ` Gregory Erwin
2022-06-25 0:40 ` Jason A. Donenfeld
2022-06-27 6:45 ` Herbert Xu
2022-06-27 9:29 ` [PATCH v3] " Jason A. Donenfeld
2022-06-27 10:49 ` [PATCH v4] " Jason A. Donenfeld
2022-06-27 11:37 ` [PATCH v5] " Jason A. Donenfeld
2022-06-27 12:07 ` [PATCH v6] " Jason A. Donenfeld
2022-06-27 12:18 ` Toke Høiland-Jørgensen
2022-06-28 1:39 ` Gregory Erwin
2022-06-28 10:46 ` Jason A. Donenfeld
2022-06-28 10:48 ` Jason A. Donenfeld
2022-06-28 10:51 ` Herbert Xu
2022-06-28 10:55 ` Jason A. Donenfeld
2022-06-28 12:05 ` Jason A. Donenfeld
2022-06-28 15:14 ` Jason A. Donenfeld
2022-06-28 1:53 ` Herbert Xu
2022-06-28 10:45 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1xh9idl.fsf@toke.dk \
--to=toke@toke.dk \
--cc=Jason@zx2c4.com \
--cc=gregerwin256@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rsalvaterra@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).