From: "Toke Høiland-Jørgensen" <toke@toke.dk>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH] mac80211: use non-zero TID only for QoS frames
Date: Wed, 05 Sep 2018 13:12:24 +0200 [thread overview]
Message-ID: <87y3cg5hbb.fsf@toke.dk> (raw)
In-Reply-To: <1536145704.3528.8.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
> On Wed, 2018-09-05 at 13:07 +0200, Toke H=C3=B8iland-J=C3=B8rgensen wrote:
>
>> > Felix wasn't really convinced, I think. He also pointed out some drive=
rs
>> > use skb->priority without checking anything, but I'm not sure we can
>> > really squash all the cases of setting skb priority easily?
>>=20
>> ~/build/linux/drivers/net/wireless $ git grep 'skb->priority =3D '
>> ath/ath9k/channel.c: skb->priority =3D 7;
>> broadcom/brcm80211/brcmfmac/core.c: skb->priority =3D cfg80211_classify=
8021d(skb, NULL);
>> broadcom/brcm80211/brcmutil/utils.c: skb->priority =3D 0;
>> intel/ipw2x00/libipw_tx.c: skb->priority =3D libipw_classify(skb);
>> marvell/mwifiex/cfg80211.c: skb->priority =3D LOW_PRIO_TID;
>> marvell/mwifiex/main.c: skb->priority =3D cfg80211_classify8021d(skb, NU=
LL);
>> marvell/mwifiex/tdls.c: skb->priority =3D MWIFIEX_PRIO_BK;
>> marvell/mwifiex/tdls.c: skb->priority =3D MWIFIEX_PRIO_VI;
>> marvell/mwifiex/tdls.c: skb->priority =3D MWIFIEX_PRIO_VI;
>> rsi/rsi_91x_core.c: skb->priority =3D q_num;
>> rsi/rsi_91x_core.c: skb->priority =3D TID_TO_WME_AC(tid);
>> rsi/rsi_91x_core.c: skb->priority =3D BE_Q;
>> rsi/rsi_91x_core.c: skb->priority =3D q_num;
>> rsi/rsi_91x_hal.c: skb->priority =3D VO_Q;
>> rsi/rsi_91x_mgmt.c: skb->priority =3D MGMT_SOFT_Q;
>> ti/wlcore/main.c: skb->priority =3D WL1271_TID_MGMT;
>>=20
>> Doesn't seem *that* excessive? Obviously there could be other cases, and
>> I haven't looked closer at any of those...
>
> That's assignments. For assignments, I guess you'd have to look at
> net/mac80211/. It's not that excessive either, but it's not in all
> places trivial to determine ...
Ah, sorry, I read that as "some drivers *set* skb->priority without
checking"...
-Toke
prev parent reply other threads:[~2018-09-05 15:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 8:00 [PATCH] mac80211: use non-zero TID only for QoS frames Johannes Berg
2018-09-05 8:06 ` Arend van Spriel
2018-09-05 8:09 ` Johannes Berg
2018-09-05 9:47 ` Toke Høiland-Jørgensen
2018-09-05 9:50 ` Johannes Berg
2018-09-05 9:56 ` Toke Høiland-Jørgensen
2018-09-05 10:56 ` Johannes Berg
2018-09-05 11:07 ` Toke Høiland-Jørgensen
2018-09-05 11:08 ` Johannes Berg
2018-09-05 11:12 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3cg5hbb.fsf@toke.dk \
--to=toke@toke.dk \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).