From: Kalle Valo <kvalo@codeaurora.org>
To: Pkshih <pkshih@realtek.com>
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"Larry.Finger\@lwfinger.net" <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 13/14] rtlwifi: access skb->data to get C2H data by macro
Date: Tue, 03 Jul 2018 09:14:44 +0300 [thread overview]
Message-ID: <87y3esrgkr.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1530597815.6330.4.camel@realtek.com> (pkshih@realtek.com's message of "Tue, 3 Jul 2018 06:03:42 +0000")
Pkshih <pkshih@realtek.com> writes:
> On Fri, 2018-06-29 at 10:30 +0300, Kalle Valo wrote:
>> Pkshih <pkshih@realtek.com> writes:
>>=20
>> > On Tue, 2018-05-29 at 08:18 +0300, Kalle Valo wrote:
>> >> <pkshih@realtek.com> writes:
>> >>=C2=A0
>> >
>> > Because C2H data is little endian order, the struct will look like
>> > struct foo {
>> > #ifdef=C2=A0__LITTLE_ENDIAN
>> >=C2=A0 u8 bar:4;
>> >=C2=A0 u8 koo:4;
>> > #else
>> >=C2=A0 u8 koo:4;
>> >=C2=A0 u8 bar:4;
>> > #endif
>> > }
>>=20
>> With u8 you don't need endian check, right? I would assume that with
>> both little and big endian bar and koo would be in the same place.
>
> I think u8 with bitfield would be different between little and big endian
> machines.
To me that does not make any sense, I have never heard about bit
endianness any of the devices I have worked on.
https://en.wikipedia.org/wiki/Endianness
--=20
Kalle Valo
next prev parent reply other threads:[~2018-07-03 6:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-18 9:29 [PATCH 00/14] rtlwifi: remove duplicate C2H handlers pkshih
2018-05-18 9:29 ` [PATCH 01/14] rtlwifi: support accurate nullfunc frame tx ack report pkshih
2018-05-29 7:18 ` [01/14] " Kalle Valo
2018-05-18 9:29 ` [PATCH 02/14] rtlwifi: remove CONNECTION_MONITOR flag pkshih
2018-05-18 9:29 ` [PATCH 03/14] rtlwifi: remove duplicate rx_packet_type definition pkshih
2018-05-18 9:29 ` [PATCH 04/14] rtlwifi: rename register-based C2H command IDs to V0 pkshih
2018-05-18 9:29 ` [PATCH 05/14] rtlwifi: remove duplicate C2H definition pkshih
2018-05-18 9:29 ` [PATCH 06/14] rtlwifi: remove unused fw C2H command ID pkshih
2018-05-18 9:30 ` [PATCH 07/14] rtlwifi: remove dummy hal_op rx_command_packet from rtl8188ee and rtl8723ae pkshih
2018-05-18 9:30 ` [PATCH 08/14] rtlwifi: Add hal_op c2h_ra_report_handler for special process pkshih
2018-05-18 9:30 ` [PATCH 09/14] rtlwifi: remove duplicate C2H handler pkshih
2018-05-18 9:30 ` [PATCH 10/14] rtlwifi: remove hal_op rx_command_packet pkshih
2018-05-18 9:30 ` [PATCH 11/14] rtlwifi: remove hal_op c2h_content_parsing pkshih
2018-05-18 9:30 ` [PATCH 12/14] rtlwifi: use sk_buff to queue C2H commands pkshih
2018-05-18 9:30 ` [PATCH 13/14] rtlwifi: access skb->data to get C2H data by macro pkshih
2018-05-29 5:18 ` Kalle Valo
2018-05-31 2:13 ` Pkshih
2018-06-29 7:30 ` Kalle Valo
2018-07-03 6:03 ` Pkshih
2018-07-03 6:14 ` Kalle Valo [this message]
2018-07-03 8:32 ` Felix Fietkau
2018-07-03 10:57 ` Kalle Valo
2018-07-03 11:01 ` Felix Fietkau
2018-07-03 15:28 ` Larry Finger
2018-05-18 9:30 ` [PATCH 14/14] rtlwifi: fix btmpinfo timeout while processing C2H_BT_INFO pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3esrgkr.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).