From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Rakesh Pillai <pillair@qti.qualcomm.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
Govind Singh <govinds@qti.qualcomm.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] ath10k: WMI: modify svc bitmap parsing for wcn3990
Date: Thu, 7 Dec 2017 15:04:55 +0000 [thread overview]
Message-ID: <87y3metw8f.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1512214248-17127-2-git-send-email-pillair@qti.qualcomm.com> (Rakesh Pillai's message of "Sat, 2 Dec 2017 17:00:45 +0530")
Rakesh Pillai <pillair@qti.qualcomm.com> writes:
> Due to the limitation of wmi tlv parsing logic, if there are
> two parameters in a wmi event with same tlv tag, we can get only
> the last value, as it overwrites the prev value of the same tlv tag.
>
> The service ready event in wcn3990 contains two parameters of the
> same tag UINT32, due to which the svc bitmap is overwritten with the
> DBS support parameter.
>
> Refactor the service ready event parsing to allow parsing two tlv
> of the same tag UINT32 for wcn3990.
>
> Signed-off-by: Rakesh Pillai <pillair@qti.qualcomm.com>
> Signed-off-by: Govind Singh <govinds@qti.qualcomm.com>
ath10k-check found a warning in this patch:
drivers/net/wireless/ath/ath10k/wmi-tlv.c:981: braces {} are not necessary =
for single statement blocks
--=20
Kalle Valo=
next prev parent reply other threads:[~2017-12-07 15:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 11:30 [PATCH v2 0/4] WMI changes for wcn3990 Rakesh Pillai
2017-12-02 11:30 ` [PATCH v2 1/4] ath10k: WMI: modify svc bitmap parsing " Rakesh Pillai
2017-12-07 15:04 ` Kalle Valo [this message]
2017-12-02 11:30 ` [PATCH v2 2/4] ath10k: WMI: Add management tx by reference support over wmi Rakesh Pillai
2017-12-07 15:06 ` Kalle Valo
2017-12-02 11:30 ` [PATCH v2 3/4] ath10k: WMI: get wmi init parameter values from hw params Rakesh Pillai
2017-12-02 11:30 ` [PATCH v2 4/4] ath10k: WMI: add hw params entry for wcn3990 Rakesh Pillai
2017-12-07 15:08 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3metw8f.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=govinds@qti.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pillair@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox